fix: market: use expiry-activation for deal weight calculation #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #291 +/- ##
======================================
Coverage 3.57% 3.57%
======================================
Files 520 520
Lines 96959 96959
======================================
Hits 3468 3468
Misses 92140 92140
Partials 1351 1351
|
|
@aarshkshah1992 Could you give this PR a review today? As I would like to have this together with the final GST v0.14.0 release. |
aarshkshah1992
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Changes here look good assuming we're okay changing the deal duration calculation like this. Looks like we already have pre-approval from Magik etc based on #237 (comment) so fine.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #237
This is the same as #237 but on top of master and with v14 included and v12 excluded.
It's a 👍 from me and @magik6k endorsed this on slack and it possibly (but maybe not) addresses a live issue being experienced by lotus-miner @ filecoin-project/lotus#12014
This apparently should have been done with the introduction of allocation term-min term-max.
As per my comment in #239 on the scope of this and what it touches: