Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement internal message task #533

Merged
merged 12 commits into from
Jul 28, 2021
Merged

Conversation

frrist
Copy link
Member

@frrist frrist commented Jun 4, 2021

Implements internal message tracking for Cron Ticks and Miner Reward Messages.

go.mod Outdated
@@ -82,3 +84,5 @@ replace (
// Supports go-ipld-prime v7
// TODO: remove once https://github.com/filecoin-project/go-hamt-ipld/pull/70 is merged to github.com/filecoin-project/go-hamt-ipld
replace github.com/filecoin-project/go-hamt-ipld/v2 => github.com/willscott/go-hamt-ipld/v2 v2.0.1-0.20210225034344-6d6dfa9b3960

replace github.com/filecoin-project/lotus => ../lotus
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other half of this lives here: filecoin-project/lotus#6389

@frrist frrist force-pushed the frrist/internal-message-tracking branch from fa66603 to dea8b03 Compare June 4, 2021 01:25
@frrist frrist mentioned this pull request Jun 4, 2021
@frrist frrist force-pushed the frrist/internal-message-tracking branch from dea8b03 to f348c9b Compare June 4, 2021 22:18
@frrist frrist changed the title implement internal message task [Blocked] implement internal message task Jun 8, 2021
@frrist frrist force-pushed the frrist/internal-message-tracking branch from f348c9b to 57c2f0b Compare July 2, 2021 21:02
@frrist frrist force-pushed the frrist/internal-message-tracking branch from 673eb90 to 12c3757 Compare July 26, 2021 20:01
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2021

Codecov Report

Merging #533 (79dae3a) into master (9e4fbda) will decrease coverage by 0.3%.
The diff coverage is 18.0%.

@@           Coverage Diff            @@
##           master    #533     +/-   ##
========================================
- Coverage    32.7%   32.4%   -0.4%     
========================================
  Files          41      41             
  Lines        3710    3751     +41     
========================================
+ Hits         1216    1217      +1     
- Misses       2321    2361     +40     
  Partials      173     173             

@frrist frrist marked this pull request as ready for review July 26, 2021 21:37
storage model.Storage
processors map[string]TipSetProcessor
messageProcessors map[string]MessageProcessor
messageExecutionProcessors map[string]MessageExecutionProcessor
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the new processor for message executions, unable to reuse the existing one since lily is required for this workflow.

@frrist frrist changed the title [Blocked] implement internal message task Implement internal message task Jul 26, 2021
})
}

// TODO(frrist): this code is commented out as it collects all internal message sent through the VM.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue for this here: #602

@frrist frrist requested a review from iand July 26, 2021 23:52
@frrist frrist linked an issue Jul 27, 2021 that may be closed by this pull request
@frrist frrist linked an issue Jul 27, 2021 that may be closed by this pull request
Copy link
Contributor

@iand iand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frrist frrist merged commit b7b9310 into master Jul 28, 2021
@frrist frrist deleted the frrist/internal-message-tracking branch July 28, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Capture internal messages
3 participants