Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish(stmgr): define ExecMonitor for message application callback #6389

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

frrist
Copy link
Member

@frrist frrist commented Jun 4, 2021

Changes here are mostly mechanical -- moving things around to accommodate the new interface, ExecMonitor. ExecMonitor replaces the ExecCallback function in the stmgr. The motivation for this change is allowing a custom ExecMonitor interface to be injected for details message tracking while monitoring lotus.

@frrist frrist force-pushed the frrist/execmonitor-interface branch from 6a52f6d to e38cfb7 Compare June 4, 2021 01:02
@frrist frrist marked this pull request as draft June 4, 2021 01:13
@frrist frrist force-pushed the frrist/execmonitor-interface branch 2 times, most recently from 40b7ecf to 053e1d4 Compare June 4, 2021 01:23
@frrist frrist force-pushed the frrist/execmonitor-interface branch from 053e1d4 to 0519c77 Compare June 7, 2021 18:03
@frrist frrist self-assigned this Jun 7, 2021
@frrist frrist marked this pull request as ready for review June 7, 2021 18:24
@frrist frrist requested review from arajasek, iand and magik6k June 7, 2021 18:24
@frrist frrist changed the title polish(stmgr): define ExecMonitor for message applicaiton callback polish(stmgr): define ExecMonitor for message application callback Jun 7, 2021
Copy link
Contributor

@iand iand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and fits what is needed for Sentinel, but I defer to a Lotus maintainer

@magik6k magik6k merged commit c98b6f6 into master Jun 8, 2021
@magik6k magik6k deleted the frrist/execmonitor-interface branch June 8, 2021 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants