Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lotus DB package #11024

Closed
Tracked by #10991
snadrus opened this issue Jun 29, 2023 · 2 comments · Fixed by #11069
Closed
Tracked by #10991

Lotus DB package #11024

snadrus opened this issue Jun 29, 2023 · 2 comments · Fixed by #11069
Assignees
Milestone

Comments

@snadrus
Copy link
Collaborator

snadrus commented Jun 29, 2023

User Story
As a storage provider I want to run the new database alongside the current lotus-miner process, and get familiar with the requirements and setup, so that I can leverage it once the SectorIndex is able to run on it.

Technical acceptence criteria

  • Both SQLX & PGX interfaces to the configuration-specified DB.
  • An IntegrationTest() setup func where the database name starts with itest_ then .IntegrationTestDropAll() will delete the database (for integration tests).

Tech Scope

An init that will sequentially run a set of upgrade scripts (0.sql 1.sql etc) until the database’s lotus-version table’s only row has a value stepped up to the latest version. A missing table is presumed identical to the need for 0.sql
The SQL files will be included in the package for simplicity.
When not specified, the database will be lotus.
Config values will be used by a wrapper called UseConfig(), and errors meaningful.
Includes building the mock.

Test Plan
An integration test will exercise the feature set of the software and the mock.

A package lotusdb which offers:
Both SQLX & PGX interfaces to the configuration-specified DB.
An init that will sequentially run a set of upgrade scripts (0.sql 1.sql etc) until the database’s lotus-version table’s only row has a value stepped up to the latest version. A missing table is presumed identical to the need for 0.sql
The SQL files will be included in the package for simplicity.
When not specified, the database will be lotus
An integration test setup where the database name starts with itest_ then .IntegrationTestDropAll() will delete the database (for integration tests).
Includes building the mock.

@rjan90 rjan90 added this to the HA WindowPoSt milestone Jun 30, 2023
@rjan90 rjan90 linked a pull request Jul 11, 2023 that will close this issue
@rjan90 rjan90 linked a pull request Aug 1, 2023 that will close this issue
@jennijuju
Copy link
Member

can this issue be closed with #11069 or there is still items left to do? did we test it already?

@snadrus
Copy link
Collaborator Author

snadrus commented Aug 8, 2023 via email

@snadrus snadrus closed this as completed Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants