-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/clusterdb #11069
feat/clusterdb #11069
Conversation
extern/filecoin-ffi
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks accidentally committed
if err != nil { | ||
t.Fatal("Could not insert: ", err) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We generally use testify / require.NoError(t, err);
I don't think this needs changing, but would be more consistent with the rest of the codebase
"time" | ||
|
||
logging "github.com/ipfs/go-log/v2" | ||
"github.com/jackc/pgx/v5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw yugabyte has a cluster-aware fork of pgx which we could consider using - https://github.com/yugabyte/pgx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we have pgx v5 and they forked v4, I'm not sure what we are missing.
But between already supporting fallback and allowing SPs to set the initial server, I don't feel a big need to move to this, especially since only 1 db instance will be common at the beginning.
node/config/types.go
Outdated
// ITest is for optimized integration testing and not | ||
// for production. Blank for default production configuration. | ||
ITest string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be needed
Proposed Changes
Introduces HarmonyDB, a DB adapter that