Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update renew-sectors with FIP-0045 logic #10328

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Conversation

arajasek
Copy link
Contributor

Related Issues

#9369

Proposed Changes

As described in #9369 (comment)

Additional Info

  • Needs a go-state-types release and integration

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@arajasek arajasek requested a review from a team as a code owner February 22, 2023 21:32
Copy link
Contributor

@ZenGround0 ZenGround0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is quite complex but I think we are structurally unable to test it since it lives on the cli. Is it possible to have tests using the cli instead of api in itests? If so this PR would ideally have a test. If not we should do some thinking about how to make this and other complex cli code testable. In a perfect world we could mock out the api to make it way easier to setup state and then run the cli command against the mock api.

documentation/en/cli-lotus-miner.md Outdated Show resolved Hide resolved
cmd/lotus-miner/sectors.go Outdated Show resolved Hide resolved
cmd/lotus-miner/sectors.go Outdated Show resolved Hide resolved
cmd/lotus-miner/sectors.go Outdated Show resolved Hide resolved
cmd/lotus-miner/sectors.go Show resolved Hide resolved
cmd/lotus-miner/sectors.go Outdated Show resolved Hide resolved
cmd/lotus-miner/sectors.go Outdated Show resolved Hide resolved
cmd/lotus-miner/sectors.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants