Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: miner: correctly count sector extensions #10544

Merged
merged 2 commits into from
Mar 30, 2023
Merged

Conversation

arajasek
Copy link
Contributor

Related Issues

#10525

Regression introduced in #10328

Proposed Changes

We weren't correctly counting the number of sectors we had queued up in the "current" extension p, and as a result we were missing extensions.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@arajasek arajasek requested a review from a team as a code owner March 22, 2023 22:03
@jennijuju
Copy link
Member

Why no test catching this? 🤔🙎🏻‍♀️

Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now this makes quite a bit more sense

@arajasek
Copy link
Contributor Author

Why no test catching this? thinking🙎🏻‍♀️

@jennijuju Because our CLI logic is basically entirely untested 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants