Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Lotus Gateway: Add missing methods - hyperspace #10417

Conversation

ArseniiPetrovich
Copy link
Contributor

@ArseniiPetrovich ArseniiPetrovich commented Mar 8, 2023

Related Issues

#10402

Proposed Changes

Add 4 methods to Lotus Gateway:

  • StateNetworkName
  • MpoolGetNonce
  • StateCall
  • StateDecodeParams

Additional Info

Required for Glif.io apps to work properly

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@ArseniiPetrovich ArseniiPetrovich requested a review from a team as a code owner March 8, 2023 00:27
@jennijuju
Copy link
Member

jennijuju commented Mar 8, 2023

@ArseniiPetrovich can we target this pr at master plz? (otherwise it might not be ended up in lotus main code base/or any release.

@jennijuju jennijuju changed the base branch from ntwk/hyperspace to master March 8, 2023 04:29
@jennijuju jennijuju changed the base branch from master to ntwk/hyperspace March 8, 2023 04:30
@jennijuju
Copy link
Member

things in master, on the other hand will get merged back into hyperspace as needed (and easier to do_

@ArseniiPetrovich
Copy link
Contributor Author

So, what are the next steps? :)
I see you changed to master and back to hyperspace

@jennijuju
Copy link
Member

So, what are the next steps? :)
I see you changed to master and back to hyperspace

Can you apply the changes to master? (The branch diff was way too big lolol)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants