Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Lotus Gateway: Add missing methods - master #10420

Merged
merged 5 commits into from
Mar 8, 2023
Merged

fix: Lotus Gateway: Add missing methods - master #10420

merged 5 commits into from
Mar 8, 2023

Conversation

ArseniiPetrovich
Copy link
Contributor

Inspired by #10417 discussions

Related Issues

#10402

Proposed Changes

Add 4 methods to Lotus Gateway:

  • StateNetworkName
  • MpoolGetNonce
  • StateCall
  • StateDecodeParams

Additional Info

Required for Glif.io apps to work properly

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@ArseniiPetrovich ArseniiPetrovich requested a review from a team as a code owner March 8, 2023 15:54
@ArseniiPetrovich ArseniiPetrovich changed the title Add missing methods master fix: Lotus Gateway: Add missing methods - master Mar 8, 2023
arajasek
arajasek reviewed Mar 8, 2023
View reviewed changes
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

magik6k
magik6k reviewed Mar 8, 2023
View reviewed changes
api/proxy_gen.go Outdated Show resolved Hide resolved
@jennijuju jennijuju added this to the v1.20.2 milestone Mar 8, 2023
@magik6k magik6k mentioned this pull request Mar 8, 2023
Merged
raulk
raulk approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but @arajasek and @jennijuju should review.

@raulk
Copy link
Member

raulk commented Mar 8, 2023

Adding backport label since @ArseniiPetrovich wants this on Hyperspace too, I believe.

@magik6k magik6k merged commit 1aac945 into filecoin-project:master Mar 8, 2023
@rjan90 rjan90 mentioned this pull request Mar 9, 2023
Closed
18 tasks
@jennijuju jennijuju mentioned this pull request Mar 10, 2023
Merged
@Fatman13 Fatman13 mentioned this pull request Mar 13, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arajasek arajasek arajasek left review comments

@raulk raulk raulk approved these changes

@magik6k magik6k magik6k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.20.2
Development

Successfully merging this pull request may close these issues.
6 participants
@ArseniiPetrovich @raulk @magik6k @arajasek @Stebalien @jennijuju