Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge/rebased v23 into v22 #10701

Closed
wants to merge 83 commits into from
Closed

Conversation

ZenGround0
Copy link
Contributor

Related Issues

Proposed Changes

The branch being merged here started its life == release/v1.22.0
Then I rebased this branch on top of release/v1.21.0
Then I merged it back into release/v1.22.0

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

arajasek and others added 30 commits March 17, 2023 13:10
chore: update ffi to increase execution parallelism
Don't enforce walking receipt tree during compaction
fix: build: drop drand incentinet servers
Co-authored-by: Jiaying Wang <42981373+jennijuju@users.noreply.github.com>
chore: merge release/v1.20.4 into releases
Update to go-state-types v0.11.0-alpha-1

Introduce dummy v11 actor bundles

Make new actors adapters

Add upgrade to Upgrade Schedules

make jen

Update to go-state-types v0.11.0-alpha-2
This is now "FVM" native. Changes include:

1. Don't treat "trace" messages like off-chain messages. E.g., don't
include CIDs, versions, etc.
2. Include IPLD codecs where applicable.
3. Remove fields that aren't filled by the FVM (timing, some errors,
code locations, etc.).
chore: backport 10372 onto release/v1.22.0
- Keep current expiration defaults on creation, extension some tests
- Update ffi
- Open splitstore in migration shed tool
- Update state root version
ZenGround0 and others added 21 commits April 19, 2023 09:31
Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com>
* Quick butterfly upgrade to sanity check

* Update butterfly artifacts

* Revert fake fix

* Give butterfly net correct genesis

* Butterfly artifacts

* Give time before upgrade

---------

Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com>
* Update butterfly artifacts

* register actors v11

* Update calibration upgrade time

* State inspection shed cmds

* Fix

* make gen

* Fix swallowed errors

* Lint fixup

---------

Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com>
* Update go-state-types

* Modify upgrade schedule and params

* Revert fip 0052

* Update gst

* docsgen

* fast butterfly migration to validate migration

* Correct epoch to match specified date

* Update actors v11

* Update changelog build version

* Update butterfly artifacts

* Fix lotus-miner init to work after upgrade

---------

Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com>
@ZenGround0 ZenGround0 requested a review from a team as a code owner April 19, 2023 20:00
@Stebalien
Copy link
Member

I'm concerned that the rebase may cause merge issues. Did you consider:

  1. Forking 1.23 off of 1.21.
  2. Merging 1.22 into 1.23.

@rjan90
Copy link
Contributor

rjan90 commented Apr 19, 2023

We should bump the version in build/version.go (to 1.23.0-rc1), and run the make docsgen and make docsgen-cli scripts. The gen-check test seems to fail because of some merge conflicts, but those should be cleaned up with the docsgen scripts.

@Stebalien
Copy link
Member

The diff there is also significantly easier to review.

@ZenGround0
Copy link
Contributor Author

Forking 1.23 off of 1.21.

I don't have branch permissions or the ability to set them and I woke up to this branch set at 1.22. If you have branch permissions and can do hard reset to 1.21 I'll do this.

Merging 1.22 into 1.23.

The rebase was a recovery from a deadend. I originally wanted to just force reset 1.23 to the rebased 1.22 on top of 1.21. I can merge 1.21 into the 1.22 base branch here instead of the rebase if you don't have merge permissions to reset to 1.21.

@jennijuju
Copy link
Member

should we close this?

@ZenGround0 ZenGround0 closed this Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants