(DO NOT MERGE) Remove semaphore that serializes access to Add/Push/PushUntrusted in MessagePool #10783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes a semaphore that serializes access to Add(), Push() and PushLimited() so that only one goroutine thread can run it at once. These methods already have a mutex guarding critical sections, but the question is whether its needed when publishing message to topics (which I guess can take a while since it calls out to libp2p and other peers).
fridrik01
changed the title
|
Talked about this with Steb, and this semaphore may be required to prevent exploitation of overloading the messagequeue, however the comment in the code for preventing lock contention should be changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROPOSAL ONLY - Do not merge
This PR removes a semaphore that actually serialized all access to the
Add(),Push()andPushUntrusted()methods inchain/messagepoolso that only one goroutine thread can run it at once.This semaphore may have be contributing to the high latency spikes we see on the glif nodes
These methods already have a mutex guarding critical sections, but the question is whether its needed when publishing message to topics (which I guess can take a while since it calls out to libp2p and other peers).