Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(DO NOT MERGE) Remove semaphore that serializes access to Add/Push/PushUntrusted in MessagePool #10783

Closed
wants to merge 1 commit into from
Closed

(DO NOT MERGE) Remove semaphore that serializes access to Add/Push/PushUntrusted in MessagePool #10783

wants to merge 1 commit into from

Commits on Apr 28, 2023

  1. Do not serialize access to Add/Push/PushLimited in MessagePool 

    This commit removes a semaphore that serializes access to Add(),
Push() and PushLimited() so that only one goroutine thread can
run it at once.

These methods already have a mutex guarding critical sections,
but the question is whether its needed when publishing message
to topics (which I guess can take a while since it calls out
to libp2p and other peers).
    @fridrik01
    fridrik01 committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    34de216 View commit details
    Browse the repository at this point in the history