Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eth: avoid panicing on start if we don't have a head #11421

Closed
wants to merge 1 commit into from

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented Nov 15, 2023


Related Issues

Proposed Changes

Check if we actually have a head before trying to pre-fill the tipset cache in the Eth module

This case shouldn't happen unless the node gets corrupted (I think?). Or maybe when starting at genesis? But there's no reason to panic regardless.

Additional Info

This really isn't the right place to do this prefill, but I don't know where it should be moved. We could move it, e.g., into ChainStore.Start, but then we'd run this on all nodes. Is that OK?

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • CI is green

This case shouldn't happen unless the node gets corrupted (I think?). Or
maybe when starting at genesis? But there's no reason to panic
regardless.
@Stebalien Stebalien requested a review from a team as a code owner November 15, 2023 14:36
@Stebalien
Copy link
Member Author

This isn't sufficient as the node will just fail when it tries to call Start.

@Stebalien
Copy link
Member Author

Testing an alternative in #11426.

@Stebalien Stebalien closed this Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant