fix: chain: make failure to load the chain state fatal #11426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, we get strange panics later.
4 tasks
Stebalien
commented
Nov 16, 2023
|
|
||
| chain := store.NewChainStore(cbs, sbs, ds, weight, j) | ||
|
|
||
| if err := chain.Load(helpers.LifecycleCtx(mctx, lc)); err != nil { | ||
| log.Warnf("loading chain state from disk: %s", err) | ||
| return nil, xerrors.Errorf("loading chain state from disk: %w", err) |
There was a problem hiding this comment.
Either:
- We have a large gap in our tests.
- Failing in this case is "just fine".
There was a problem hiding this comment.
Note: We'll fail anyways when we call Start below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes
Make failure to load the chain state fatal. Otherwise, we get strange panics later.
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps