fix: lotus-provider: send errs then retries despite being sent #11492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
reviewed
Dec 6, 2023
| @@ -281,7 +281,7 @@ func NewSender(api SenderAPI, signer SignerAPI, db *harmonydb.DB) (*Sender, *Sen | |||
| // API nodes | |||
| // | |||
| // Send is also currently more strict about required parameters than MpoolPushMessage | |||
| func (s *Sender) Send(ctx context.Context, msg *types.Message, mss *api.MessageSendSpec, reason string) (cid.Cid, error) { | |||
| func (s *Sender) Send(ctx context.Context, msg *types.Message, mss *api.MessageSendSpec, reason string, taskID harmonytask.TaskID) (cid.Cid, error) { | |||
There was a problem hiding this comment.
This task id is not what should go into the message_sends table
| @@ -350,7 +350,10 @@ func (s *Sender) Send(ctx context.Context, msg *types.Message, mss *api.MessageS | |||
| var sigCidStr, sendError string | |||
| var sendSuccess *bool | |||
|
|
|||
| err = s.db.QueryRow(ctx, `select signed_cid, send_success, send_error from message_sends where send_task_id = $1`, taskAdder).Scan(&sigCidStr, &sendSuccess, &sendError) | |||
| err = s.db.QueryRow(ctx, ` | |||
There was a problem hiding this comment.
oh, we should be persisting the taskID in the call to taskAdder a few lines above - this is the ID of the message send task (which is separate from the recover/submit task IDs)
magik6k
changed the title
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps