Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lotus-provider: Wait for the correct taskID #11493

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Dec 6, 2023

Related Issues

Fixes the issue fixed by #11492

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@magik6k magik6k requested a review from a team as a code owner December 6, 2023 19:54
@magik6k magik6k requested review from snissn and arajasek December 6, 2023 19:54
@magik6k
Copy link
Contributor Author

magik6k commented Dec 6, 2023

Verified on my setup, does appear to work

@magik6k
Copy link
Contributor Author

magik6k commented Dec 6, 2023

Ooor not quite, has problems with recoveries

@magik6k
Copy link
Contributor Author

magik6k commented Dec 6, 2023

				2023-12-06T22:48:40.558+0100    ERROR   harmonytask     harmonytask/task_type_handler.go:148    Do() returned error     {"type": "WdPostRecover", "id": "20240", "error": "sending declare recoveries message: getting
				 cid for task: can't scan into dest[0]: cannot scan NULL into *string", "errorVerbose": "sending declare recoveries message:\n    github.com/filecoin-project/lotus/provider/lpwindow.(*WdPostRecoverDeclareTask).Do\n
				        /home/magik6k/github.com/filecoin-project/go-lotus/provider/lpwindow/recover_task.go:196\n  - getting cid for task:\n    github.com/filecoin-project/lotus/provider/lpmessage.(*Sender).Send\n        /home/ma
				gik6k/github.com/filecoin-project/go-lotus/provider/lpmessage/sender.go:362\n  - can't scan into dest[0]: cannot scan NULL into *string"}

@magik6k
Copy link
Contributor Author

magik6k commented Dec 6, 2023

Works now!

yugabyte@10:yugabyte> select * from lotus.harmony_task_history where "name" != 'WinPost' order by work_end desc limit 20
+------+---------+---------------+----------------------------+----------------------------+----------------------------+--------+----------------------------------------------------------------------------------->
| id   | task_id | name          | posted                     | work_start                 | work_end                   | result | err                                                                               >
|------+---------+---------------+----------------------------+----------------------------+----------------------------+--------+----------------------------------------------------------------------------------->
| 6328 | 21657   | WdPostSubmit  | 2023-12-06 22:05:08.456314 | 2023-12-06 23:05:17.183435 | 2023-12-06 23:05:20.396742 | True   |                                                                                   >
| 6221 | 21530   | SendMessage   | 2023-12-06 22:05:17.201831 | 2023-12-06 23:05:20.261077 | 2023-12-06 23:05:20.374178 | True   |                                                                                   >
| 6327 | 21656   | WdPostSubmit  | 2023-12-06 22:05:08.435629 | 2023-12-06 23:05:11.127736 | 2023-12-06 23:05:14.371956 | True   |                                                                                   >
| 6220 | 21523   | SendMessage   | 2023-12-06 22:05:11.146326 | 2023-12-06 23:05:14.146574 | 2023-12-06 23:05:14.211431 | True   |                                                                                   >
| 6325 | 21704   | WdPostRecover | 2023-12-06 22:04:47.171619 | 2023-12-06 23:05:01.980728 | 2023-12-06 23:05:05.188947 | True   |                                                                                   >
| 6324 | 21650   | SendMessage   | 2023-12-06 22:05:02.009275 | 2023-12-06 23:05:05.045007 | 2023-12-06 23:05:05.152473 | True   |                                                                                   >
| 6323 | 21703   | WdPostRecover | 2023-12-06 22:04:47.15848  | 2023-12-06 23:04:55.942181 | 2023-12-06 23:04:59.157496 | True   |                                                                                   >
| 6322 | 21643   | SendMessage   | 2023-12-06 22:04:55.977956 | 2023-12-06 23:04:58.95631  | 2023-12-06 23:04:59.018823 | True   |                                                                                   >
| 6502 | 21702   | WdPost        | 2023-12-06 22:04:47.151178 | 2023-12-06 23:04:52.91555  | 2023-12-06 23:04:53.03256  | True   |                                                                                   >
| 6501 | 21701   | WdPost        | 2023-12-06 22:04:47.130797 | 2023-12-06 23:04:49.875437 | 2023-12-06 23:04:50.134476 | True   |                                                                                   >
-- below entries before the fix in this PR
| 6018 | 20240   | WdPostRecover | 2023-12-06 21:48:19.636287 | 2023-12-06 22:59:01.898803 | 2023-12-06 22:59:05.136062 | False  | error: sending declare recoveries message: parsing signed cid: invalid cid: can't >
| 6115 | 20854   | SendMessage   | 2023-12-06 21:59:01.94531  | 2023-12-06 22:59:04.977049 | 2023-12-06 22:59:05.062691 | True   |                                                                                   >
| 6114 | 20240   | WdPostRecover | 2023-12-06 21:48:19.636287 | 2023-12-06 22:58:55.768411 | 2023-12-06 22:58:58.971456 | False  | error: sending declare recoveries message: parsing signed cid: invalid cid: can't >
| 6113 | 20847   | SendMessage   | 2023-12-06 21:58:55.802724 | 2023-12-06 22:58:58.86965  | 2023-12-06 22:58:58.908152 | True   |                                                                                   >
| 6017 | 20240   | WdPostRecover | 2023-12-06 21:48:19.636287 | 2023-12-06 22:58:49.717251 | 2023-12-06 22:58:52.921232 | False  | error: sending declare recoveries message: parsing signed cid: invalid cid: can't >
| 6016 | 20843   | SendMessage   | 2023-12-06 21:58:49.752656 | 2023-12-06 22:58:52.738645 | 2023-12-06 22:58:52.785528 | True   |                                                                                   >
| 6112 | 20240   | WdPostRecover | 2023-12-06 21:48:19.636287 | 2023-12-06 22:58:43.672097 | 2023-12-06 22:58:46.900857 | False  | error: sending declare recoveries message: parsing signed cid: invalid cid: can't >
| 6111 | 20836   | SendMessage   | 2023-12-06 21:58:43.721202 | 2023-12-06 22:58:46.700839 | 2023-12-06 22:58:46.734072 | True   |                                                                                   >
| 6110 | 20240   | WdPostRecover | 2023-12-06 21:48:19.636287 | 2023-12-06 22:58:37.613949 | 2023-12-06 22:58:40.914416 | False  | error: sending declare recoveries message: parsing signed cid: invalid cid: can't >
| 6109 | 20748   | SendMessage   | 2023-12-06 21:58:37.743387 | 2023-12-06 22:58:40.639423 | 2023-12-06 22:58:40.707652 | True   |                                                                                   >
+------+---------+---------------+----------------------------+----------------------------+----------------------------+--------+----------------------------------------------------------------------------------->
SELECT 20

@snadrus snadrus merged commit d32b8be into master Dec 6, 2023
87 of 89 checks passed
@snadrus snadrus deleted the fix/lp-send-taskid-wait branch December 6, 2023 22:16
rjan90 pushed a commit that referenced this pull request Dec 11, 2023
fix: lotus-provider: Wait for the correct taskID
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants