Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sync): remove checks bypass when we submit the block #4192

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

schomatis
Copy link
Contributor

@schomatis schomatis commented Oct 6, 2020

Just to get the conversation started and run all the tests.

Background on the removed code: #17 (comment).

@schomatis schomatis mentioned this pull request Oct 7, 2020
@schomatis schomatis marked this pull request as ready for review October 19, 2020 15:05
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly we needed this for the early code to work correctly, I think it's ok to remove, though @whyrusleeping should confirm

@schomatis schomatis mentioned this pull request Oct 22, 2020
@whyrusleeping
Copy link
Member

I don't think devnets will work with this? not sure

@magik6k
Copy link
Contributor

magik6k commented Nov 20, 2020

Nope, devnets work fine with this (including debug/fake proof mode)

@magik6k magik6k merged commit b0bb369 into master Jan 12, 2021
@magik6k magik6k deleted the schomatis/sync/remove-self-bypass branch January 12, 2021 13:52
bibibong pushed a commit to EpiK-Protocol/go-epik that referenced this pull request Jan 13, 2021
…tis/sync/remove-self-bypass

fix(sync): remove checks bypass when we submit the block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants