review parent weight #4540
Closed
review parent weight #4540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schomatis
commented
Oct 22, 2020
| @@ -16,6 +16,8 @@ import ( | |||
|
|
|||
| var zero = types.NewInt(0) | |||
|
|
|||
| // Compute the weight of this `TipSet` based on its `ParentWeight()` | |||
| // and FIXME: COMPLETE THIS SENTENCE. | |||
There was a problem hiding this comment.
Insert suggestion here completing this doc.
schomatis
commented
Oct 22, 2020
Comment on lines
-566
to
-569
| if syncer.store.GetHeaviestTipSet().ParentWeight().GreaterThan(maybeHead.ParentWeight()) { | ||
| return nil | ||
| } | ||
|
|
There was a problem hiding this comment.
This is already checked in InformNewHead and it depends on a value that is controlled by the sender so this extra check just adds a fake sense of security.
|
Test failing because |
|
Incorporating #4192 to avoid the self-bypass and follow a single path. |
|
This PR exceeded its original purpose and will require some more design consideration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First in a series of small boring PRs about the sync logic.