Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add scripts to validate phase2 output and parameter #1249

Closed
wants to merge 1 commit into from

Conversation

vmx
Copy link
Contributor

@vmx vmx commented Aug 6, 2020

This commit adds two scripts. One is to validate that the trusted
setup phase2 result matches the published parameter files.

The other one is to verify that a .params file (and the corresponding
.vk file) is part of the parameters.json.

This commit adds two scripts. One is to validate that the trusted
setup phase2 result matches the published parameter files.

The other one is to verify that a `.params` file (and the corresponding
`.vk file`) is part of the `parameters.json`.
@cryptonemo
Copy link
Collaborator

Looks good, but I'll approve after I have a chance to test

@DrPeterVanNostrand
Copy link
Contributor

Maybe these scripts should live in the phase2-attestations repo? Which is where I putting the rest of the validation commands.

@cryptonemo
Copy link
Collaborator

Hrm, not sure, but I was thinking they could live here so that I can easily run them. Not that I can't get the other repo and test it out ...

Between both of you, what's the best way to verify and be happy with the merged files and the split v28 params that are output?

@DrPeterVanNostrand
Copy link
Contributor

DrPeterVanNostrand commented Aug 6, 2020

@nemo If this way is easier, then that's fine with me. I just wanted to ask

I was going to have participant's run split-keys on the merged phase2 files and then verify checksums against the v28 split files. I was probably going to re-upload the split files to s3

So something like this, which is in vmx's scripts:

$ ./phase2 split-keys <merged file>
$ split_digest=$(cat <.vk file> <.params file> <.contribs file> | b2sum | awk '{print $1}'); echo "${split_digest}  <merged file>" | b2sum -c

@porcuquine
Copy link
Collaborator

I approved pending @cryptonemo's test, if it can happen before we need this to test verification instructions.

Copy link
Collaborator

@cryptonemo cryptonemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify phase2 script tested well.

@vmx
Copy link
Contributor Author

vmx commented Aug 7, 2020

I've split this PR into two pieces.

The scripts are byte-identical to the ones of this PR.

@vmx vmx closed this Aug 7, 2020
@vmx vmx deleted the phase2-verification-scripts branch December 19, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants