-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add scripts to validate phase2 output and parameter #1249
Conversation
This commit adds two scripts. One is to validate that the trusted setup phase2 result matches the published parameter files. The other one is to verify that a `.params` file (and the corresponding `.vk file`) is part of the `parameters.json`.
Looks good, but I'll approve after I have a chance to test |
Maybe these scripts should live in the |
Hrm, not sure, but I was thinking they could live here so that I can easily run them. Not that I can't get the other repo and test it out ... Between both of you, what's the best way to verify and be happy with the merged files and the split v28 params that are output? |
@nemo If this way is easier, then that's fine with me. I just wanted to ask I was going to have participant's run So something like this, which is in vmx's scripts:
|
I approved pending @cryptonemo's test, if it can happen before we need this to test verification instructions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verify phase2 script tested well.
I've split this PR into two pieces.
The scripts are byte-identical to the ones of this PR. |
This commit adds two scripts. One is to validate that the trusted
setup phase2 result matches the published parameter files.
The other one is to verify that a
.params
file (and the corresponding.vk file
) is part of theparameters.json
.