feat: add script to verify parameter checksums in parameters.json #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a script to verify that a `.params` file (and the corresponding `.vk file`) is part of the `parameters.json` and has the correct checksums.
vmx
requested review from
cryptonemo,
dignifiedquire and
porcuquine
as code owners
|
Will approve as soon as this is tested well. |
cryptonemo
requested changes
Aug 7, 2020
scripts/verify-parameters-json.sh
Outdated
| #!/bin/sh | ||
|
|
||
| # This script verifies that a given `.params` file (and the corresponding | ||
| # `.vk` file) is part of `parameters.json` as has the correct digest. |
There was a problem hiding this comment.
Minor typo 'as has the' = 'and has the'
scripts/verify-parameters-json.sh
Outdated
| # utilities (`basename`, `head`, `grep`) as well as have `jq` and `b2sum` | ||
| # installed. | ||
| # | ||
| # The input a `parameter.json` file and a `.params' file. |
There was a problem hiding this comment.
Wording is weird ('The input a')
scripts/verify-parameters-json.sh
Outdated
|
|
||
| if [ "${#}" -ne 1 ]; then | ||
| echo "Verify that a given .params file (and the corresponding .vk file)" | ||
| echo "is part of parameters.json as has the correct digest." |
porcuquine
previously approved these changes
Aug 7, 2020
There was a problem hiding this comment.
Approved based on review of previous, though wording fixes per @cryptonemo would be worth making.
|
@vmx This tested well! |
|
@vmx I updated this, and also included a small fix that I did manually while verifying. I'd like to merge after CI is complete. |
|
@cryptonemo Thanks a lot for taking this on. |
cryptonemo
approved these changes
Aug 7, 2020
porcuquine
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a script to verify that a
.paramsfile (and the corresponding.vk file) is part of theparameters.jsonand has the correct checksums.I extracted this script from this PR: #1249