Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of message application #979

Closed
dignifiedquire opened this issue Sep 26, 2018 · 2 comments
Closed

Improve performance of message application #979

dignifiedquire opened this issue Sep 26, 2018 · 2 comments

Comments

@dignifiedquire
Copy link
Contributor

I noticed that message application is actually very slow, executing even a couple of hundred messages is not fast. The majority here comes from the storage reading and writing.

Refs
@frrist
Copy link
Member

frrist commented Sep 27, 2018

This appears to effect things like gengen (used by IPTB setup scripts) since it applies messages inorder to give power to an address.

@dignifiedquire dignifiedquire mentioned this issue Sep 27, 2018
Merged
@dignifiedquire
Copy link
Contributor Author

We should upgrade go-ipld-cbor and friends to the latest version of ipfs/go-ipld-cbor, which now uses refmt and has multiple perf relevant improvements for us

dignifiedquire added a commit that referenced this issue Sep 27, 2018
@dignifiedquire
perf: improve actor storage performance (#990)
ce40e9e 
* perf: improve actor storage performance

This minimizes the amount of marshal & unmarshal calls being made when using `actor.WithStorage`.

I used the test `TestTipSetWeightDeep` as benchmark and went from `140s` to `61s`.

When applying ipfs/go-ipld-cbor#45 the time goes down to `45s`.

Warning: this reduces the strictness of the vm memory barrier with the rest of filecoin, but we accept this as a tradeof for now, to improve performance. 

Ref #979
@anorth anorth closed this as completed Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@anorth @dignifiedquire @frrist