attempt to allocate a bit less #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Traverse once. 2. Avoid fmt.
ghost
assigned 
dignifiedquire
approved these changes
Sep 25, 2018
|
will try out in my code later today and report back |
|
It seems about 5% faster in my tests (note I patched this in, on an older version, as I haven't updated to |
|
Well... that's still a win. |
|
After fixing some things in my code this makes my tests go from |
dignifiedquire
added a commit
to filecoin-project/venus
that referenced
this pull request
Sep 27, 2018
* perf: improve actor storage performance This minimizes the amount of marshal & unmarshal calls being made when using `actor.WithStorage`. I used the test `TestTipSetWeightDeep` as benchmark and went from `140s` to `61s`. When applying ipfs/go-ipld-cbor#45 the time goes down to `45s`. Warning: this reduces the strictness of the vm memory barrier with the rest of filecoin, but we accept this as a tradeof for now, to improve performance. Ref #979
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dignifiedquire this may not help but could you test if you have time? The internal benchmarks don't seem to capture real-world gc issues very well.