Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming suggestions #49

Open
AttilaMihaly opened this issue Apr 2, 2020 · 3 comments
Open

Naming suggestions #49

AttilaMihaly opened this issue Apr 2, 2020 · 3 comments
Labels
discussion needed An issue that needs further discussion.

Comments

@AttilaMihaly
Copy link
Member

LetDefinition -> LetInDefinition or LetDefinitionIn
Destructure -> DestructureIn
@AttilaMihaly AttilaMihaly added the discussion needed An issue that needs further discussion. label Apr 2, 2020
@AttilaMihaly AttilaMihaly mentioned this issue Apr 2, 2020
Merged
@DamianReeves
Copy link
Member

Morphir.IR.Value -> Morphir.IR.Expr

@AttilaMihaly
Copy link
Member Author

Morphir.IR.Value -> Morphir.IR.Expr

Oh, I thought you meant Morphir.IR.Value.Expr and Morphir.IR.Type.Expr

@DamianReeves
Copy link
Member

Your suggestion is better

sfc-gh-lfallasavendano added a commit to Snowflake-Labs/morphir-elm that referenced this issue Dec 13, 2023
@sfc-gh-lfallasavendano
Add support for some list functions (finos#49)
a4f1d2c 
* Add support for some list functions

Adds basic support for:
- `List.map` with lambda returning record
- `List.map` with lambda returning a single value
- `List.filter` with lambda predicate
- `List.sum` with `List.map` as its collection

* Fixes for Code review comments
sfc-gh-lfallasavendano added a commit to Snowflake-Labs/morphir-elm that referenced this issue Dec 13, 2023
@sfc-gh-lfallasavendano
Add support for some list functions (finos#49)
9d1bed3 
* Add support for some list functions

Adds basic support for:
- `List.map` with lambda returning record
- `List.map` with lambda returning a single value
- `List.filter` with lambda predicate
- `List.sum` with `List.map` as its collection

* Fixes for Code review comments
sfc-gh-lfallasavendano added a commit to Snowflake-Labs/morphir-elm that referenced this issue Jan 2, 2024
@sfc-gh-lfallasavendano
Add support for some list functions (finos#49)
0ac2903 
* Add support for some list functions

Adds basic support for:
- `List.map` with lambda returning record
- `List.map` with lambda returning a single value
- `List.filter` with lambda predicate
- `List.sum` with `List.map` as its collection

* Fixes for Code review comments
sfc-gh-lfallasavendano added a commit to Snowflake-Labs/morphir-elm that referenced this issue Jan 8, 2024
@sfc-gh-lfallasavendano
Add support for some list functions (finos#49)
b8d8d5d 
* Add support for some list functions

Adds basic support for:
- `List.map` with lambda returning record
- `List.map` with lambda returning a single value
- `List.filter` with lambda predicate
- `List.sum` with `List.map` as its collection

* Fixes for Code review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion needed An issue that needs further discussion.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DamianReeves @AttilaMihaly