Increase test coverage for persistent cache indexing #5213

cherylEnkidu · 2023-07-31T16:27:43Z

No description provided.

github-actions · 2023-07-31T16:27:58Z

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

google-oss-bot · 2023-07-31T16:36:23Z

Coverage Report ¹

Affected Products

firebase-firestore
Overall coverage changed from 44.63% (f2a0fa3) to 44.62% (5647871) by -0.00%.
Filename Base (f2a0fa3) Merge (5647871) Diff
LruGarbageCollector.java 97.27% 93.64% -3.64%
RemoteSerializer.java 79.62% 79.83% +0.21%
SetMutation.java 94.44% 97.22% +2.78%
Target.java 95.79% 96.26% +0.47%

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/aMnx1F0Kss.html

github-actions · 2023-07-31T16:39:18Z

Unit Test Results

  164 files -   656   164 suites - 656 2m 43s ⏱️ - 36m 5s
1 205 tests - 3 797 1 189 ✔️ - 3 791 16 💤 -   5 0 ❌ - 1
2 410 runs - 7 503 2 378 ✔️ - 7 492 32 💤 - 10 0 ❌ - 1

Results for commit b6c3465. ± Comparison against base commit f2a0fa3.

♻️ This comment has been updated with latest results.

google-oss-bot · 2023-07-31T16:49:51Z

Size Report ¹

Affected Products

firebase-firestore
Type Base (f2a0fa3) Merge (5647871) Diff
aar 1.36 MB 1.36 MB +2 B (+0.0%)
apk (release) 3.95 MB 3.95 MB +28 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/u3mAql2E70.html

google-oss-bot · 2023-07-31T17:07:15Z

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

This report is for comparing the base commit (f2a0fa3) and the CI merge commit (5647871)
Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
- f2a0fa3: https://storage.googleapis.com/firebase-sdk-metric-reports/EqaFRJZijz/index.html
- 5647871: https://storage.googleapis.com/firebase-sdk-metric-reports/HzeXJ1sSMW/index.html

Startup Times

`fire-fst`

Device Statistics Distributions

oriole-32

Percentile	`f2a0fa3`	`5647871`	Diff	Significant (?)
p10	315 ±19 μs	324 ±21 μs	+9.16 μs (+2.9%)	NO
p25	333 ±23 μs	336 ±26 μs	+3.27 μs (+1.0%)	NO
p50	354 ±31 μs	365 ±49 μs	+10.9 μs (+3.1%)	NO
p75	391 ±50 μs	429 ±108 μs	+38.5 μs (+9.9%)	NO
p90	461 ±83 μs	575 ±260 μs	+114 μs (+24.7%)	NO

20 test runs in comparison

Commit	Test Runs
`f2a0fa3`	2023-08-16_20:49:23.572658_AiVl 2023-08-16_20:49:23.576531_vDAe 2023-08-16_20:49:23.576550_BHxJ 2023-08-16_20:49:23.576559_AdUb 2023-08-16_20:49:23.576565_ZzWZ 2023-08-16_20:49:23.576571_uQvL 2023-08-16_20:49:23.576578_csqp 2023-08-16_20:49:23.576584_Onsb 2023-08-16_20:49:23.576596_eKYW 2023-08-16_20:49:23.576615_JBAF
`5647871`	2023-08-17_15:29:46.641322_BvyJ 2023-08-17_15:29:46.646752_HKZr 2023-08-17_15:29:46.646764_sXMi 2023-08-17_15:29:46.646773_tqTT 2023-08-17_15:29:46.646779_DzJJ 2023-08-17_15:29:46.646785_ypkN 2023-08-17_15:29:46.646790_IzEv 2023-08-17_15:29:46.646948_Nwef 2023-08-17_15:29:46.646954_ukaJ 2023-08-17_15:29:46.646960_sLkC

redfin-30

Percentile	`f2a0fa3`	`5647871`	Diff	Significant (?)
p10	598 ±27 μs	627 ±63 μs	+28.6 μs (+4.8%)	NO
p25	615 ±32 μs	651 ±86 μs	+36.3 μs (+5.9%)	NO
p50	636 ±39 μs	715 ±202 μs	+79.2 μs (+12.5%)	NO
p75	668 ±49 μs	771 ±245 μs	+103 μs (+15.4%)	NO
p90	737 ±153 μs	875 ±372 μs	+138 μs (+18.8%)	NO

20 test runs in comparison

Commit	Test Runs
`f2a0fa3`	2023-08-16_20:49:23.572658_AiVl 2023-08-16_20:49:23.576531_vDAe 2023-08-16_20:49:23.576550_BHxJ 2023-08-16_20:49:23.576559_AdUb 2023-08-16_20:49:23.576565_ZzWZ 2023-08-16_20:49:23.576571_uQvL 2023-08-16_20:49:23.576578_csqp 2023-08-16_20:49:23.576584_Onsb 2023-08-16_20:49:23.576596_eKYW 2023-08-16_20:49:23.576615_JBAF
`5647871`	2023-08-17_15:29:46.641322_BvyJ 2023-08-17_15:29:46.646752_HKZr 2023-08-17_15:29:46.646764_sXMi 2023-08-17_15:29:46.646773_tqTT 2023-08-17_15:29:46.646779_DzJJ 2023-08-17_15:29:46.646785_ypkN 2023-08-17_15:29:46.646790_IzEv 2023-08-17_15:29:46.646948_Nwef 2023-08-17_15:29:46.646954_ukaJ 2023-08-17_15:29:46.646960_sLkC

`timeToInitialDisplay`

Device Statistics Distributions

oriole-32

Percentile	`f2a0fa3`	`5647871`	Diff	Significant (?)
p10	204 ±6 ms	205 ±3 ms	+1.54 ms (+0.8%)	NO
p25	210 ±7 ms	212 ±3 ms	+2.09 ms (+1.0%)	NO
p50	218 ±8 ms	219 ±3 ms	+1.49 ms (+0.7%)	NO
p75	226 ±8 ms	229 ±4 ms	+3.37 ms (+1.5%)	NO
p90	235 ±9 ms	242 ±4 ms	+7.12 ms (+3.0%)	NO

20 test runs in comparison

Commit	Test Runs
`f2a0fa3`	2023-08-16_20:49:23.572658_AiVl 2023-08-16_20:49:23.576531_vDAe 2023-08-16_20:49:23.576550_BHxJ 2023-08-16_20:49:23.576559_AdUb 2023-08-16_20:49:23.576565_ZzWZ 2023-08-16_20:49:23.576571_uQvL 2023-08-16_20:49:23.576578_csqp 2023-08-16_20:49:23.576584_Onsb 2023-08-16_20:49:23.576596_eKYW 2023-08-16_20:49:23.576615_JBAF
`5647871`	2023-08-17_15:29:46.641322_BvyJ 2023-08-17_15:29:46.646752_HKZr 2023-08-17_15:29:46.646764_sXMi 2023-08-17_15:29:46.646773_tqTT 2023-08-17_15:29:46.646779_DzJJ 2023-08-17_15:29:46.646785_ypkN 2023-08-17_15:29:46.646790_IzEv 2023-08-17_15:29:46.646948_Nwef 2023-08-17_15:29:46.646954_ukaJ 2023-08-17_15:29:46.646960_sLkC

redfin-30

Percentile	`f2a0fa3`	`5647871`	Diff	Significant (?)
p10	243 ±3 ms	265 ±4 ms	+22.5 ms (+9.3%)	YES
p25	249 ±3 ms	272 ±4 ms	+22.9 ms (+9.2%)	YES
p50	256 ±3 ms	280 ±4 ms	+23.6 ms (+9.2%)	YES
p75	264 ±3 ms	289 ±5 ms	+24.7 ms (+9.4%)	YES
p90	274 ±4 ms	304 ±6 ms	+29.2 ms (+10.7%)	YES

20 test runs in comparison

Commit	Test Runs
`f2a0fa3`	2023-08-16_20:49:23.572658_AiVl 2023-08-16_20:49:23.576531_vDAe 2023-08-16_20:49:23.576550_BHxJ 2023-08-16_20:49:23.576559_AdUb 2023-08-16_20:49:23.576565_ZzWZ 2023-08-16_20:49:23.576571_uQvL 2023-08-16_20:49:23.576578_csqp 2023-08-16_20:49:23.576584_Onsb 2023-08-16_20:49:23.576596_eKYW 2023-08-16_20:49:23.576615_JBAF
`5647871`	2023-08-17_15:29:46.641322_BvyJ 2023-08-17_15:29:46.646752_HKZr 2023-08-17_15:29:46.646764_sXMi 2023-08-17_15:29:46.646773_tqTT 2023-08-17_15:29:46.646779_DzJJ 2023-08-17_15:29:46.646785_ypkN 2023-08-17_15:29:46.646790_IzEv 2023-08-17_15:29:46.646948_Nwef 2023-08-17_15:29:46.646954_ukaJ 2023-08-17_15:29:46.646960_sLkC

https://storage.googleapis.com/firebase-sdk-metric-reports/VYtnvAYoK9/index.html

dconeybe

Just one tiny nit about line length.

Note that in the web port of client-side index auto creation (firebase/firebase-js-sdk#7542) I added "testing hooks" that provide a way for integration tests to verify that the indexes are (or are not) created, as expected. This is something we should consider porting to android and ios IMO. The "testing hooks" infrastructure exists in android and ios too (it was created for the bloom filter work) so we'd just need to add to it.

firebase-firestore/src/androidTest/java/com/google/firebase/firestore/IndexingTest.java

cherylEnkidu · 2023-08-15T19:58:03Z

As discussed in the meeting, testing hook will be added in a separated PR. Tracking number: b/296100693

dconeybe

A few minor nits, but mostly LGTM.

firebase-firestore/src/androidTest/java/com/google/firebase/firestore/FirestoreTest.java

firebase-firestore/src/androidTest/java/com/google/firebase/firestore/IndexingTest.java

...base-firestore/src/test/java/com/google/firebase/firestore/local/SQLiteIndexManagerTest.java

firebase-firestore/src/test/java/com/google/firebase/firestore/local/SQLiteLocalStoreTest.java

google-oss-bot added the size/XS label Jul 31, 2023

cherylEnkidu force-pushed the cheryllin/readability branch from 003fb22 to b85f853 Compare July 31, 2023 16:28

cherylEnkidu force-pushed the cheryllin/readability branch 3 times, most recently from 99b25a4 to 09498d1 Compare August 10, 2023 18:51

google-oss-bot added size/L and removed size/XS labels Aug 10, 2023

cherylEnkidu force-pushed the cheryllin/readability branch 2 times, most recently from a921927 to d326e29 Compare August 11, 2023 03:48

google-oss-bot added size/M and removed size/L labels Aug 11, 2023

cherylEnkidu changed the title ~~Improve readability~~ Increase test coverage for persistent cache indexing Aug 11, 2023

cherylEnkidu requested a review from dconeybe August 11, 2023 04:34

cherylEnkidu assigned dconeybe Aug 11, 2023

dconeybe requested changes Aug 11, 2023

View reviewed changes

firebase-firestore/src/androidTest/java/com/google/firebase/firestore/IndexingTest.java Outdated Show resolved Hide resolved

dconeybe assigned cherylEnkidu and unassigned dconeybe Aug 11, 2023

google-oss-bot added size/L and removed size/M labels Aug 15, 2023

dconeybe requested changes Aug 16, 2023

View reviewed changes

cherylEnkidu assigned dconeybe and unassigned cherylEnkidu Aug 17, 2023

dconeybe approved these changes Aug 17, 2023

View reviewed changes

firebase-firestore/src/test/java/com/google/firebase/firestore/local/SQLiteLocalStoreTest.java Show resolved Hide resolved

dconeybe assigned cherylEnkidu Aug 17, 2023

dconeybe removed their assignment Aug 17, 2023

cherylEnkidu added 4 commits August 17, 2023 11:12

Improve readability

6112ff8

optimize deleteAllIndexes tests

cfb1bec

backport tests from web

768f9b3

Address Feedback2

b6c3465

cherylEnkidu force-pushed the cheryllin/readability branch from 87685ff to b6c3465 Compare August 17, 2023 15:12

cherylEnkidu added the no-changelog label Aug 17, 2023

cherylEnkidu merged commit d27ff15 into master Aug 17, 2023

cherylEnkidu deleted the cheryllin/readability branch August 17, 2023 19:16

dconeybe mentioned this pull request Sep 1, 2023

Firestore: Move local store index auto-creation unit tests into the proper file firebase/firebase-js-sdk#7601

Merged

limsaehyun pushed a commit to limsaehyun/firebase-android-sdk that referenced this pull request Sep 5, 2023

Increase test coverage for persistent cache indexing (firebase#5213)

e58e468

dconeybe mentioned this pull request Sep 7, 2023

Firestore: Increase test coverage for persistent cache indexing firebase/firebase-js-sdk#7613

Merged

firebase locked and limited conversation to collaborators Sep 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Increase test coverage for persistent cache indexing #5213

Increase test coverage for persistent cache indexing #5213

cherylEnkidu commented Jul 31, 2023

github-actions bot commented Jul 31, 2023 •

edited

Loading

google-oss-bot commented Jul 31, 2023 •

edited

Loading

`firebase-firestore`

github-actions bot commented Jul 31, 2023 •

edited

Loading

google-oss-bot commented Jul 31, 2023 •

edited

Loading

`firebase-firestore`

google-oss-bot commented Jul 31, 2023 •

edited

Loading

`fire-fst`

`timeToInitialDisplay`

dconeybe left a comment

cherylEnkidu commented Aug 15, 2023

dconeybe left a comment

Increase test coverage for persistent cache indexing #5213

Increase test coverage for persistent cache indexing #5213

Conversation

cherylEnkidu commented Jul 31, 2023

github-actions bot commented Jul 31, 2023 • edited Loading

📝 PRs merging into main branch

google-oss-bot commented Jul 31, 2023 • edited Loading

Coverage Report 1

Affected Products

firebase-firestore

Test Logs

github-actions bot commented Jul 31, 2023 • edited Loading

Unit Test Results

google-oss-bot commented Jul 31, 2023 • edited Loading

Size Report 1

Affected Products

firebase-firestore

Test Logs

google-oss-bot commented Jul 31, 2023 • edited Loading

Startup Time Report 1

Notes

Startup Times

fire-fst

timeToInitialDisplay

dconeybe left a comment

Choose a reason for hiding this comment

cherylEnkidu commented Aug 15, 2023

dconeybe left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 31, 2023 •

edited

Loading

google-oss-bot commented Jul 31, 2023 •

edited

Loading

Coverage Report ¹

`firebase-firestore`

github-actions bot commented Jul 31, 2023 •

edited

Loading

google-oss-bot commented Jul 31, 2023 •

edited

Loading

Size Report ¹

`firebase-firestore`

google-oss-bot commented Jul 31, 2023 •

edited

Loading

Startup Time Report ¹

`fire-fst`

`timeToInitialDisplay`