You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #7542 and #7587 I added local store unit tests for client-side index auto-creation logic into local_store.test.ts, which contains the generic unit tests that apply to both "memory" local store and "indexeddb" local store. But since client-side indexing is purely a feature of indexeddb local store, I should have put the tests into local_store_indexeddb.test.ts. This PR moves the tests into the correct file. This has the added benefit that uses a more modern and more readable "await" style testing rather than the promise chaining used in the generic tests.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Could you please also add test, testCanAutoCreateIndexesWorksWithOrQuery , in SQLiteLocalStoreTest.java ?
That test was part of firebase/firebase-android-sdk#5213, which I plan to port in its entirety. I'd like to do that in a separate PR though. Are you ok to merge this PR and port that test in a subsequent PR?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #7542 and #7587 I added local store unit tests for client-side index auto-creation logic into
local_store.test.ts, which contains the generic unit tests that apply to both "memory" local store and "indexeddb" local store. But since client-side indexing is purely a feature of indexeddb local store, I should have put the tests intolocal_store_indexeddb.test.ts. This PR moves the tests into the correct file. This has the added benefit that uses a more modern and more readable "await" style testing rather than the promise chaining used in the generic tests.