Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the condition that checks if window is available #1819

Merged
merged 1 commit into from
May 24, 2019
Merged

fix the condition that checks if window is available #1819

merged 1 commit into from
May 24, 2019

Conversation

Feiyang1
Copy link
Member

fixes #1817

@Feiyang1 Feiyang1 mentioned this pull request May 24, 2019
Closed
thebrianchen
thebrianchen approved these changes May 24, 2019
View reviewed changes
Copy link

@thebrianchen thebrianchen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! Unfortunately I'm not a code owner yet.

schmidt-sebastian
schmidt-sebastian reviewed May 24, 2019
View reviewed changes
packages/firestore/src/platform_browser/browser_platform.ts
@@ -47,7 +47,7 @@ export class BrowserPlatform implements Platform {
}

newConnectivityMonitor(): ConnectivityMonitor {
if (this.window !== undefined) {
if (this.window) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could also just be typeof window !== 'undefined'

Copy link
Member Author

@Feiyang1 Feiyang1 May 24, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.window does exactly that, so I figured we should just use it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schmidt-sebastian mind approving the PR? Thanks!

@Feiyang1 Feiyang1 merged commit 31438c1 into master May 24, 2019
@Feiyang1 Feiyang1 deleted the fei-firestorefix branch May 24, 2019 20:22
@schmidt-sebastian schmidt-sebastian mentioned this pull request May 27, 2019
Closed
@firebase firebase locked and limited conversation to collaborators Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

@thebrianchen thebrianchen thebrianchen approved these changes

Assignees

@thebrianchen thebrianchen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Firebase 6.0.4 and web worker
3 participants
@Feiyang1 @thebrianchen @schmidt-sebastian