Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the condition that checks if window is available #1819

Merged
merged 1 commit into from
May 24, 2019
Merged

fix the condition that checks if window is available #1819

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/firestore/src/platform_browser/browser_platform.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export class BrowserPlatform implements Platform {
}

newConnectivityMonitor(): ConnectivityMonitor {
if (this.window !== undefined) {
if (this.window) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could also just be typeof window !== 'undefined'

Copy link
Member Author

@Feiyang1 Feiyang1 May 24, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.window does exactly that, so I figured we should just use it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schmidt-sebastian mind approving the PR? Thanks!

return new BrowserConnectivityMonitor();
} else {
return new NoopConnectivityMonitor();
Expand Down