Fix JWT format and interop with Storage Emulator. Fixes #3442.

[abeisgoat]

In rules-unit-testing, our naive implementation of unsigned JWT implementation wasn't spec compliant so it was breaking the storage emulator

[changeset-bot]

⚠️ No Changeset found

Latest commit: f602b9c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[abeisgoat]

I broke... something this is gonna need a bit more work

[samtstern]

@abeisgoat looks like the rules have begun failing, which probably means the token is not encoded correctly:

INFO: operation failed: 
Property custom_claim is undefined on object. for 'update' @ L3
com.google.cloud.datastore.core.exception.DatastoreException: 
Property custom_claim is undefined on object. for 'update' @ L3
	at com.google.cloud.datastore.core.exception.DatastoreException$Builder.build(DatastoreException.java:111)

[alejo4373]

Hi All! Any updates on this? I'm running into firebase-tools/issues/3442

[yuchenshi]

BLOCKING: We also need to update https://github.com/firebase/firebase-js-sdk/blob/master/packages/util/src/emulator.ts#L138

I suggest we just switch to base64url and trim the padding ourselves instead of introducing another dependency since we don't want to bloat @firebase/util which is used in almost all firebase packages. Plus it's a much smaller change and easier to reason about, especially given the broken decoding right now.

[yuchenshi]

This needs use base64url instead of base64.

firebase-js-sdk/packages/util/src/crypt.ts

Line 339 in 5d31e21

export const base64Encode = function (str: string): string {

is the utility for that. I think we still need to trim padding ourselves though.

[abeisgoat]

@yuchenshi plz take a look and I'm not sure why things are failing after the package.json merge, any idea what that token error is?

[yuchenshi]

Let's get this in first and then in a later PR I'll port the fix to https://github.com/firebase/firebase-js-sdk/blob/master/packages/util/src/emulator.ts#L138

[yuchenshi]

Fixes firebase/firebase-tools#3442.

This will be included in the next release.