Implement mockUserToken for Storage and fix bugs. #5282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuchenshi
requested review from
avolkovi,
egilmorez,
hiranya911,
jsdt,
sam-gc and
schmidt-sebastian
as code owners
🦋 Changeset detectedLatest commit: b86fa54 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Changeset File Check
|
yuchenshi
commented
Aug 11, 2021
yuchenshi
commented
Aug 11, 2021
| @@ -34,7 +35,13 @@ export interface DataSnapshot { | |||
|
|
|||
| export interface Database { | |||
| app: FirebaseApp; | |||
| useEmulator(host: string, port: number): void; | |||
| useEmulator( | |||
There was a problem hiding this comment.
Turns out I forgot this in #4792. Fixing in this PR.
Binary Size ReportAffected SDKs
Test Logs |
Size Analysis Report |
Feiyang1
suggested changes
Aug 12, 2021
yuchenshi
force-pushed
the
ys/storage-mockUserToken
branch
from
54101cd
to
b86fa54
Compare
Feiyang1
approved these changes
Aug 13, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements
mockUserTokenfor Storage, and updates Firestore and Database for consistency. See below.It also ported the JWT format fix from #5002.
This PR had to make many minor changes to many packages and I'd appreciate a global review and approval.
Docs: All docstrings are already approved before or copies for approved docstrings before.
Testing
API Changes
API changes internally approved at go/firebase-rules-unit-testing-next-api (Googlers only). The only change after that is to allow a raw mock token string (go/safer-rules-unit-testing#heading=h.rhuum73tfz77 also Googlers only)