Implement emulators discovery in RUTv2. #5334

yuchenshi · 2021-08-20T16:21:04Z

No description provided.

changeset-bot · 2021-08-20T16:21:06Z

⚠️ No Changeset found

Latest commit: 3c77191

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2021-08-20T16:23:49Z

Changeset File Check ⚠️

Changeset formatting error in following file:

Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
If this change doesn't need a release, run `changeset add --empty`.

sam-gc

Nice tests

google-oss-bot · 2021-08-20T19:42:58Z

Binary Size Report

Affected SDKs

@firebase/rules-unit-testing

Type Base (37cee9e) Head (70167d2) Diff

main 2.76 kB 7.40 kB +4.64 kB (+168.0%)

Test Logs

Base (37cee9ec): https://github.com/firebase/firebase-js-sdk/actions/runs/1151763708
Head (70167d20): https://github.com/firebase/firebase-js-sdk/actions/runs/1152118035

google-oss-bot · 2021-08-20T19:46:51Z

Size Analysis Report

Affected Products

No changes between base commit (37cee9e) and head commit (70167d2).

Test Logs

* Add new types and function stubs. * Fix types for testEnv.emulators. * Add util functions. * Add withFunctionTriggersDisabled overloads. * Improve typing for EmulatorConfig. * Fix tests. * Rename test_environment.ts to initialize.ts. * Add a dummy test to make CI pass. * Implement emulators discovery. * Use URL object from global. * Fix unreachable error code.

* Split storage and storage-compat (#5271) * separate storage-compat from storage * commit * fix tests * wat? * build storage-compat * save * fixing some compat tests * format * update import path * format * get compat tests to work * format * update package json * cleanup * format * address comments * Update packages/storage-compat/test/unit/service.test.ts Co-authored-by: Christina Holland <chholland@google.com> * add missing dev dep * Update packages/storage-compat/package.json * Update packages/storage-compat/package.json * Update deps after v8 release * update compat version * Split database and database-compat (#5276) * compile database * pass database tests * compile and test database-compat * pass all tests * prettier * cleanup * fix lint * address comments * what is going on with ci * use correct case in import path * uppercase * rename * fix component name * Repo refactoring for v9 (#5325) * rename folders * rename folders * migrate app and app-compat * migrate installations and analytics * migrate app check * migrate auth * migrate functions * migrate messaging * migrate performance * migrate remoteconfig * remove v8 code * update versions * migrate firebase * fix merge issues * save * fix firebase builds * update changeset config * update build scripts * update release script * fix functions typings * remove redundant typings * update path * treat external dependencies correctly * fix lint * remove firestore-compat references * fix build issues * update build scripts * update pkg json * fix test * fix some tests * fix some tests * fix integration tests * fixes * fix dep * update ci tests * resolve todos * remove exp references * docgen build * export FirebaseError (#5349) * firebase packaging update (#5348) * Fei v9 main firestore (#5319) * compile firestore * update typings path * compile firestore compat * lint compat * make test work * get most tests work * build * remove special paths * update firestore-compat pkg json * fix merge issues * Simplify bundles * Prettier * Fix Bundle compile * Fix build * address comments * console build * Fix all tests * Prettier * fix merge issues * fix typo * update paths * app-exp * fix lint * correct path * fix * fix compat lint * fix firestore integration * fix workflow * update dep * Always block on Auth (#5340) * Always block on Auth * Don't block on token if already recevied * fix lint * build firestore * remove memory only tests * fix firebase integration tests * enable more build and tests * add firestore-compat to firebase dep * fix auth compat class * enable auth test * auth package doc * Update API reports Co-authored-by: Sebastian Schmidt <mrschmidt@google.com> Co-authored-by: Feiyang1 <Feiyang1@users.noreply.github.com> * rebasing * Create registerMessagingCompat.ts * Add changeset for v9 (#5350) * add changeset * publish messaging interop * add firestore bumps * update changeset * Revert "Create registerMessagingCompat.ts" This reverts commit 0b95a51. * Revert "rebasing" This reverts commit a8bf697. * Update index.d.ts (#5355) * Fix Context Check in `Messaging-Compat` (#5353) * Add Rules Unit Testing v2 skeleton for v9 release (#5352) * Reset package for next major version. * Switch emulator script to node-fetch. * Migrate the other request call to fetch. * Update packages/rules-unit-testing/package.json Co-authored-by: Feiyang <feiyangc@google.com> * Create stale-ducks-live.md * Revert version change. Co-authored-by: Feiyang <feiyangc@google.com> * fix import path (#5356) * Add new types and function stubs for RUT vNext. (#5316) * Add new types and function stubs. * Fix types for testEnv.emulators. * Add util functions. * Add withFunctionTriggersDisabled overloads. * Improve typing for EmulatorConfig. * Fix tests. * Rename test_environment.ts to initialize.ts. * Add a dummy test to make CI pass. * Implement emulators discovery in RUTv2. (#5334) * Add new types and function stubs. * Fix types for testEnv.emulators. * Add util functions. * Add withFunctionTriggersDisabled overloads. * Improve typing for EmulatorConfig. * Fix tests. * Rename test_environment.ts to initialize.ts. * Add a dummy test to make CI pass. * Implement emulators discovery. * Use URL object from global. * Fix unreachable error code. * Implement most of RUTv2 features. (#5343) * Implement most of RUTv2 features. * Switch to compat instances. * Remove legacy code. * Use public typings for release (#5358) * use public typings for storage * use public typings for database * Implement rest of RUTv2 features. (#5360) * Implement loading rules and withFunctionTriggersDisabled. * Implement clearFirestore and storage. * Add missing await. * Add default bucketUrl. * Use alternative method to clear bucket. * Use default param (review feedback). * Storage typing updates (#5359) * rename to StorageError * more type safety * Update API reports * update api report Co-authored-by: Feiyang1 <Feiyang1@users.noreply.github.com> * correct component name * fix installtions-compat typing * remove rules-unit-testing from ignore list * reenable things * support mjs files * correct matching pattern * transform only @firebase/util * use public types for database doc * transform all but compat packages Co-authored-by: Sebastian Schmidt <mrschmidt@google.com> Co-authored-by: Feiyang1 <Feiyang1@users.noreply.github.com> Co-authored-by: kai <zwu52@uw.edu> Co-authored-by: Yuchen Shi <yuchenshi@google.com> Co-authored-by: Kai Wu <zwu52@users.noreply.github.com>

yuchenshi assigned sam-gc Aug 20, 2021

yuchenshi requested review from avolkovi and sam-gc as code owners August 20, 2021 16:21

yuchenshi changed the title ~~Implement emulators discovery.~~ Implement emulators discovery in RUTv2. Aug 20, 2021

sam-gc approved these changes Aug 20, 2021

View reviewed changes

yuchenshi force-pushed the ys/rut-v2 branch from a91b157 to 37cee9e Compare August 20, 2021 18:59

yuchenshi requested review from Feiyang1, hiranya911 and hsubox76 as code owners August 20, 2021 18:59

yuchenshi force-pushed the ys/rut-v2-discovery branch from dab0404 to 0e97152 Compare August 20, 2021 19:02

yuchenshi added the testing-sdk testing with emulator label Aug 21, 2021

yuchenshi force-pushed the ys/rut-v2 branch from 37cee9e to a8d6b63 Compare August 23, 2021 18:18

yuchenshi force-pushed the ys/rut-v2-discovery branch from 64a673a to a3092d2 Compare August 23, 2021 18:21

yuchenshi added 8 commits August 23, 2021 15:47

Add new types and function stubs.

651de39

Fix types for testEnv.emulators.

3b22ff8

Add util functions.

e133780

Add withFunctionTriggersDisabled overloads.

ddcfbc4

Improve typing for EmulatorConfig.

36de953

Fix tests.

f4bb720

Rename test_environment.ts to initialize.ts.

8898fd0

Add a dummy test to make CI pass.

c5b94a0

yuchenshi force-pushed the ys/rut-v2 branch from a8d6b63 to c5b94a0 Compare August 23, 2021 22:47

yuchenshi requested a review from egilmorez as a code owner August 23, 2021 22:47

yuchenshi added 3 commits August 23, 2021 15:47

Implement emulators discovery.

9b37dff

Use URL object from global.

6529422

Fix unreachable error code.

2c36135

yuchenshi force-pushed the ys/rut-v2-discovery branch from a3092d2 to 2c36135 Compare August 23, 2021 22:48

Base automatically changed from ys/rut-v2 to fei-v9-main August 23, 2021 23:26

Merge branch 'fei-v9-main' into ys/rut-v2-discovery

3c77191

yuchenshi merged commit da32b29 into fei-v9-main Aug 23, 2021

yuchenshi deleted the ys/rut-v2-discovery branch August 23, 2021 23:27

firebase locked and limited conversation to collaborators Sep 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement emulators discovery in RUTv2. #5334

Implement emulators discovery in RUTv2. #5334

yuchenshi commented Aug 20, 2021

changeset-bot bot commented Aug 20, 2021 •

edited

Loading

github-actions bot commented Aug 20, 2021 •

edited

Loading

sam-gc left a comment

google-oss-bot commented Aug 20, 2021 •

edited

Loading

`@firebase/rules-unit-testing`

google-oss-bot commented Aug 20, 2021 •

edited

Loading

Affected Products

Test Logs

Implement emulators discovery in RUTv2. #5334

Implement emulators discovery in RUTv2. #5334

Conversation

yuchenshi commented Aug 20, 2021

changeset-bot bot commented Aug 20, 2021 • edited Loading

⚠️ No Changeset found

github-actions bot commented Aug 20, 2021 • edited Loading

Changeset File Check ⚠️

sam-gc left a comment

Choose a reason for hiding this comment

google-oss-bot commented Aug 20, 2021 • edited Loading

Binary Size Report

Affected SDKs

@firebase/rules-unit-testing

Test Logs

google-oss-bot commented Aug 20, 2021 • edited Loading

Size Analysis Report

Affected Products

Test Logs

changeset-bot bot commented Aug 20, 2021 •

edited

Loading

github-actions bot commented Aug 20, 2021 •

edited

Loading

google-oss-bot commented Aug 20, 2021 •

edited

Loading

`@firebase/rules-unit-testing`

google-oss-bot commented Aug 20, 2021 •

edited

Loading