Repo refactoring #5345

Feiyang1 · 2021-08-22T04:37:51Z

changeset-bot · 2021-08-22T04:37:54Z

🦋 Changeset detected

Latest commit: ed709e6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 39 packages

Name	Type
@firebase/rules-unit-testing	Major
firebase	Major
@firebase/firestore	Major
@firebase/firestore-compat	Minor
@firebase/firestore-types	Minor
@firebase/analytics	Minor
@firebase/analytics-compat	Minor
@firebase/analytics-types	Minor
@firebase/app	Minor
@firebase/app-check	Minor
@firebase/app-check-compat	Minor
@firebase/app-check-types	Minor
@firebase/app-compat	Minor
@firebase/app-types	Minor
@firebase/auth	Minor
@firebase/auth-compat	Minor
@firebase/auth-types	Minor
@firebase/database	Minor
@firebase/database-compat	Minor
@firebase/database-types	Minor
@firebase/functions	Minor
@firebase/functions-compat	Minor
@firebase/functions-types	Minor
@firebase/installations	Minor
@firebase/installations-compat	Minor
@firebase/installations-types	Minor
@firebase/messaging	Minor
@firebase/messaging-compat	Minor
@firebase/messaging-types	Minor
@firebase/messaging-interop-types	Minor
@firebase/performance	Minor
@firebase/performance-compat	Minor
@firebase/performance-types	Minor
@firebase/remote-config	Minor
@firebase/remote-config-compat	Minor
@firebase/remote-config-types	Minor
@firebase/storage	Minor
@firebase/storage-compat	Minor
@firebase/storage-types	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-cla · 2021-08-22T04:37:56Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

github-actions · 2021-08-22T04:40:47Z

Changeset File Check ⚠️

Warning: This PR modifies files in the following packages but they have not been included in the changeset file:
- @firebase/component
Make sure this was intentional.

google-oss-bot · 2021-08-22T05:01:18Z

Binary Size Report

Affected SDKs

@firebase/database

Type Base (7818176) Head (4980d39) Diff

browser 296 kB 247 kB -48.9 kB (-16.5%)

main 299 kB 280 kB -19.2 kB (-6.4%)

module 296 kB 247 kB -48.9 kB (-16.5%)
@firebase/database-compat

Type Base (7818176) Head (4980d39) Diff

browser 86.6 kB 17.9 kB -68.7 kB (-79.4%)

main 103 kB 22.9 kB -79.7 kB (-77.7%)

module 86.6 kB 17.9 kB -68.7 kB (-79.4%)
@firebase/storage

Type Base (7818176) Head (4980d39) Diff

browser 64.1 kB 52.2 kB -11.9 kB (-18.6%)

main 55.8 kB 53.8 kB -1.95 kB (-3.5%)

module 64.1 kB 52.2 kB -11.9 kB (-18.6%)
@firebase/storage-compat

Type Base (7818176) Head (4980d39) Diff

browser 10.2 kB 5.67 kB -4.50 kB (-44.2%)

main 29.3 kB 8.72 kB -20.6 kB (-70.3%)

module 10.2 kB 5.67 kB -4.50 kB (-44.2%)

`firebase`

Type	Base (`7818176`)	Head (`4980d39`)	Diff
firebase-database.js	188 kB	120 kB	-68.0 kB (-36.2%)
firebase-storage.js	45.0 kB	17.2 kB	-27.8 kB (-61.8%)
firebase.js	896 kB	808 kB	-88.0 kB (-9.8%)

Test Logs

Base (78181760): https://github.com/firebase/firebase-js-sdk/actions/runs/1152446783
Head (4980d392): https://github.com/firebase/firebase-js-sdk/actions/runs/1155030229

google-oss-bot · 2021-08-22T05:10:46Z

Size Analysis Report

Affected Products

No changes between base commit (7818176) and head commit (f1d3ec9).

Test Logs

google-cla · 2021-08-22T05:52:53Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-08-23T17:23:29Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-08-23T17:51:04Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-08-23T18:11:47Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-08-23T18:42:56Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-08-23T18:55:21Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-08-23T20:20:26Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-08-23T20:25:57Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-08-23T20:28:55Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-08-23T21:35:26Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

* add changeset * publish messaging interop * add firestore bumps * update changeset

This reverts commit 0b95a51.

This reverts commit a8bf697.

* Reset package for next major version. * Switch emulator script to node-fetch. * Migrate the other request call to fetch. * Update packages/rules-unit-testing/package.json Co-authored-by: Feiyang <feiyangc@google.com> * Create stale-ducks-live.md * Revert version change. Co-authored-by: Feiyang <feiyangc@google.com>

* Add new types and function stubs. * Fix types for testEnv.emulators. * Add util functions. * Add withFunctionTriggersDisabled overloads. * Improve typing for EmulatorConfig. * Fix tests. * Rename test_environment.ts to initialize.ts. * Add a dummy test to make CI pass.

* Add new types and function stubs. * Fix types for testEnv.emulators. * Add util functions. * Add withFunctionTriggersDisabled overloads. * Improve typing for EmulatorConfig. * Fix tests. * Rename test_environment.ts to initialize.ts. * Add a dummy test to make CI pass. * Implement emulators discovery. * Use URL object from global. * Fix unreachable error code.

* Implement most of RUTv2 features. * Switch to compat instances. * Remove legacy code.

* use public typings for storage * use public typings for database

* Implement loading rules and withFunctionTriggersDisabled. * Implement clearFirestore and storage. * Add missing await. * Add default bucketUrl. * Use alternative method to clear bucket. * Use default param (review feedback).

* rename to StorageError * more type safety * Update API reports * update api report Co-authored-by: Feiyang1 <Feiyang1@users.noreply.github.com>

Feiyang1 added the v9 label Aug 22, 2021

Feiyang1 added this to the v9 GA milestone Aug 22, 2021

Feiyang1 requested review from avolkovi, hiranya911, hsubox76, jsdt, sam-gc, schmidt-sebastian and yuchenshi as code owners August 22, 2021 04:37

Feiyang1 requested review from alikn, bojeil-google, egilmorez, erikeldridge, zijianjoy and zwu52 as code owners August 22, 2021 05:52

zwu52 and others added 14 commits August 23, 2021 19:02

Create registerMessagingCompat.ts

db87505

Add changeset for v9 (#5350)

d2b44ca

* add changeset * publish messaging interop * add firestore bumps * update changeset

Revert "Create registerMessagingCompat.ts"

03fa80a

This reverts commit 0b95a51.

Revert "rebasing"

4134bb5

This reverts commit a8bf697.

Update index.d.ts (#5355)

53e2128

Fix Context Check in Messaging-Compat (#5353)

f1ecbbe

fix import path (#5356)

68eb7a0

Implement most of RUTv2 features. (#5343)

4bd7577

* Implement most of RUTv2 features. * Switch to compat instances. * Remove legacy code.

Use public typings for release (#5358)

09387d7

* use public typings for storage * use public typings for database

Implement rest of RUTv2 features. (#5360)

a9a4560

* Implement loading rules and withFunctionTriggersDisabled. * Implement clearFirestore and storage. * Add missing await. * Add default bucketUrl. * Use alternative method to clear bucket. * Use default param (review feedback).

Storage typing updates (#5359)

636ee41

* rename to StorageError * more type safety * Update API reports * update api report Co-authored-by: Feiyang1 <Feiyang1@users.noreply.github.com>

Feiyang1 force-pushed the fei-v9-main branch from 1ee66b2 to 636ee41 Compare August 24, 2021 02:02

Feiyang1 added 9 commits August 23, 2021 19:04

correct component name

c834862

fix installtions-compat typing

5c11c6f

remove rules-unit-testing from ignore list

fc19400

reenable things

c0050a5

support mjs files

df891e8

correct matching pattern

d37075e

transform only @firebase/util

bf5ddda

use public types for database doc

10362fe

transform all but compat packages

ed709e6

Feiyang1 changed the title ~~[WIP] Repo refactoring~~ Repo refactoring Aug 24, 2021

hsubox76 approved these changes Aug 24, 2021

View reviewed changes

Feiyang1 merged commit cdada6c into master Aug 24, 2021

Feiyang1 deleted the fei-v9-main branch August 24, 2021 20:56

google-oss-bot mentioned this pull request Aug 24, 2021

Version Packages #5362

Merged

firebase locked and limited conversation to collaborators Sep 24, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Repo refactoring #5345

Repo refactoring #5345

Feiyang1 commented Aug 22, 2021 •

edited

Loading

changeset-bot bot commented Aug 22, 2021 •

edited

Loading

google-cla bot commented Aug 22, 2021

github-actions bot commented Aug 22, 2021 •

edited

Loading

google-oss-bot commented Aug 22, 2021

`@firebase/database`

`@firebase/database-compat`

`@firebase/storage`

`@firebase/storage-compat`

`firebase`

google-oss-bot commented Aug 22, 2021 •

edited

Loading

Affected Products

Test Logs

google-cla bot commented Aug 22, 2021

google-cla bot commented Aug 23, 2021

google-cla bot commented Aug 23, 2021

google-cla bot commented Aug 23, 2021

google-cla bot commented Aug 23, 2021

google-cla bot commented Aug 23, 2021

google-cla bot commented Aug 23, 2021

google-cla bot commented Aug 23, 2021

google-cla bot commented Aug 23, 2021

google-cla bot commented Aug 23, 2021

Repo refactoring #5345

Repo refactoring #5345

Conversation

Feiyang1 commented Aug 22, 2021 • edited Loading

changeset-bot bot commented Aug 22, 2021 • edited Loading

🦋 Changeset detected

google-cla bot commented Aug 22, 2021

github-actions bot commented Aug 22, 2021 • edited Loading

Changeset File Check ⚠️

google-oss-bot commented Aug 22, 2021

Binary Size Report

Affected SDKs

@firebase/database

@firebase/database-compat

@firebase/storage

@firebase/storage-compat

firebase

Test Logs

google-oss-bot commented Aug 22, 2021 • edited Loading

Size Analysis Report

Affected Products

Test Logs

google-cla bot commented Aug 22, 2021

google-cla bot commented Aug 23, 2021

google-cla bot commented Aug 23, 2021

google-cla bot commented Aug 23, 2021

google-cla bot commented Aug 23, 2021

google-cla bot commented Aug 23, 2021

google-cla bot commented Aug 23, 2021

google-cla bot commented Aug 23, 2021

google-cla bot commented Aug 23, 2021

google-cla bot commented Aug 23, 2021

Feiyang1 commented Aug 22, 2021 •

edited

Loading

changeset-bot bot commented Aug 22, 2021 •

edited

Loading

github-actions bot commented Aug 22, 2021 •

edited

Loading

`@firebase/database`

`@firebase/database-compat`

`@firebase/storage`

`@firebase/storage-compat`

`firebase`

google-oss-bot commented Aug 22, 2021 •

edited

Loading