Merge pull request #12 from firebolt-db/run_twice_workaround

temp workaround for false approximate match
firebolt-db · Nov 17, 2021 · 47dfc52 · 47dfc52
2 parents 9ae398e + 129f80f
commit 47dfc52
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 9 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,12 @@
 # Changelog
 
+
+## v.0.21.3
+
+## Changes
+
+- temporary workaround for #11 where running models twice fails [#12](https://github.com/firebolt-db/dbt-firebolt/pull/12)
+
 ## v.0.21.2
 
 ### Readme

diff --git a/dbt/adapters/firebolt/__version__.py b/dbt/adapters/firebolt/__version__.py
@@ -1 +1 @@
-version = "0.21.2"
+version = "0.21.3"
diff --git a/dbt/include/firebolt/macros/materializations/table.sql b/dbt/include/firebolt/macros/materializations/table.sql
@@ -2,21 +2,27 @@
 {# Note that a nearly identical materialization appears
    in table.sql #}
   {%- set identifier = model['alias'] -%} {# alias comes from where? #}
-  {%- set old_relation = adapter.get_relation(database=database,
-                                              schema=schema,
-                                              identifier=identifier) -%}
+
+  {# Temporary workaround to issue with adapter.get_relation() until
+     the following are resolved:
+     https://github.com/firebolt-db/dbt-firebolt/issues/11
+     https://github.com/dbt-labs/dbt-core/issues/4187
+     the hack is to always drop the view/table if it already exists rather than
+     checking the db first to see if it exists.
+   #}
   {%- set target_relation = api.Relation.create(database=database,
                                                 schema=schema,
                                                 identifier=identifier,
                                                 type='table') -%}
-  {%- set exists_as_table = (old_relation is not none and old_relation.is_table) -%}
-  {%- set exists_as_view = (old_relation is not none and old_relation.is_view) -%}
+  {%- set target_relation_view = api.Relation.create(database=database,
+                                                     schema=schema,
+                                                     identifier=identifier,
+                                                     type='view') -%}
 
   {{ run_hooks(pre_hooks) }}
 
-  {% if old_relation is not none %}
-    {% do adapter.drop_relation(old_relation) %}
-  {% endif %}
+  {% do adapter.drop_relation(target_relation) %}
+  {% do adapter.drop_relation(target_relation_view) %}
 
   -- build model
   {% call statement('main') -%}