-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
temp workaround for false approximate match #12
Conversation
verified it works. |
@octavianzarzu30 if this looks good to you, I can release this change as 0.21.3 tomorrow. |
yep looks good, have even tried it today :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One formatting change, one documentation request.
Co-authored-by: Eric Ford <ima-hima@users.noreply.github.com>
…/dbt-firebolt into run_twice_workaround
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
And thanks for the additional comment. It actually did help my conception.
fixes: #11
#8 might be closer to the permanent solution, but I'm still bottoming out on root cause and will likely need to meet w/ @jtcohen6 sometime next week.
this isn't a permanent fix, but it will work in the short-term, while we dive deep on the source of the
adapter.get_relation
issuean overly-simplified normal operation for the table materialization is:
old_relation
Relation
object with the three-part name, and atype
property (so we know if it exists as aview
or as atable
)None
old_relation
is notNone
, drop the pre-existing relation.however, because we currently do not support views, if we assume that there are no views currently in the database, then we don't need to step 2 above. instead we can always just call
DROP TABLE <TABLE_NAME> IF EXISTS
, because:... IF EXISTS
clause