Skip to content
This repository has been archived by the owner on Feb 15, 2021. It is now read-only.

Escaping version format on docker version checker #141

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

danielsuguimoto
Copy link
Member

@fabriciojs @dbpolito I'm trying to fix the bug we faced with start command on a WSL2 environment. I haven't tested it because I don't have a Windows environment here, but I'm suspecting that the bug's cause is the single quote inside the command to format docker version output. But even if this pull request doesn't fix the bug, it would be nice to be merged because is more safe if we escape quoted args...and I have added new tests.

@codecov
Copy link

codecov bot commented Jul 11, 2020

Codecov Report

Merging #141 into master will increase coverage by 2.44%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #141      +/-   ##
============================================
+ Coverage     81.22%   83.67%   +2.44%     
- Complexity      402      403       +1     
============================================
  Files            83       83              
  Lines          1124     1127       +3     
============================================
+ Hits            913      943      +30     
+ Misses          211      184      -27     
Impacted Files Coverage Δ Complexity Δ
app/Checker.php 100.00% <100.00%> (+64.28%) 15.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c503d5d...fb11706. Read the comment docs.

@fabriciojs fabriciojs merged commit 7cfa515 into fireworkweb:master Jul 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants