Skip to content
This repository has been archived by the owner on Feb 15, 2021. It is now read-only.

Escaping version format on docker version checker #141

Merged
merged 1 commit into from
Jul 13, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions app/Checker.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
use App\Builder\Builder;
use App\Builder\Docker;
use App\Builder\DockerCompose;
use App\Builder\Escaped;

class Checker
{
Expand Down Expand Up @@ -33,7 +34,7 @@ public function dockerVersion()
{
if (is_null($this->dockerVersion)) {
$this->dockerVersion = $this->version(
Docker::make("version --format '{{.Server.Version}}'")
$this->dockerVersionCommandBuilder('{{.Server.Version}}')
);
}

Expand All @@ -44,7 +45,7 @@ public function dockerApiVersion()
{
if (is_null($this->dockerApiVersion)) {
$this->dockerApiVersion = $this->version(
Docker::make("version --format '{{.Server.APIVersion}}'")
$this->dockerVersionCommandBuilder('{{.Server.APIVersion}}')
);
}

Expand Down Expand Up @@ -99,6 +100,15 @@ public function checkDockerIsRunning(): bool
return $exitCode === 0;
}

protected function dockerVersionCommandBuilder(string $format): Builder
{
return Docker::make(
'version',
'--format',
Escaped::make($format)
);
}

protected function version(Builder $builder)
{
$exitCode = $this->commandExecutor->runQuietly($builder);
Expand Down
147 changes: 147 additions & 0 deletions tests/Unit/CheckerTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,147 @@
<?php

namespace Tests\Unit;

use Tests\TestCase;
use App\Checker;
use App\CommandExecutor;

class CheckerTest extends TestCase
{
public function testDockerVersion()
{
$this->mockCommandExecutorOutput(0, Checker::DOCKER_MIN_VERSION);

$checker = resolve(Checker::class);

$this->assertEquals($checker->dockerVersion(), Checker::DOCKER_MIN_VERSION);
}

public function testDockerApiVersion()
{
$this->mockCommandExecutorOutput(0, Checker::DOCKER_API_MIN_VERSION);

$checker = resolve(Checker::class);

$this->assertEquals($checker->dockerApiVersion(), Checker::DOCKER_API_MIN_VERSION);
}

public function testDockerComposeVersion()
{
$this->mockCommandExecutorOutput(0, Checker::DOCKER_COMPOSE_MIN_VERSION);

$checker = resolve(Checker::class);

$this->assertEquals($checker->dockerComposeVersion(), Checker::DOCKER_COMPOSE_MIN_VERSION);
}

public function testValidDockerVersion()
{
$this->mockCommandExecutorOutput(0, Checker::DOCKER_MIN_VERSION);

$checker = resolve(Checker::class);

$this->assertTrue($checker->checkDocker());
}

public function testInvalidDockerVersion()
{
$this->mockCommandExecutorOutput(0, '0.0.0');

$checker = resolve(Checker::class);

$this->assertFalse($checker->checkDocker());
}

public function testValidDockerApiVersion()
{
$this->mockCommandExecutorOutput(0, Checker::DOCKER_API_MIN_VERSION);

$checker = resolve(Checker::class);

$this->assertTrue($checker->checkDockerApi());
}

public function testInvalidDockerApiVersion()
{
$this->mockCommandExecutorOutput(0, '0.0.0');

$checker = resolve(Checker::class);

$this->assertFalse($checker->checkDockerApi());
}

public function testValidDockerComposeVersion()
{
$this->mockCommandExecutorOutput(0, Checker::DOCKER_COMPOSE_MIN_VERSION);

$checker = resolve(Checker::class);

$this->assertTrue($checker->checkDockerCompose());
}

public function testInvalidDockerComposeVersion()
{
$this->mockCommandExecutorOutput(0, '0.0.0');

$checker = resolve(Checker::class);

$this->assertFalse($checker->checkDockerCompose());
}

public function testErrorDockerVersionCommand()
{
$this->mockCommandExecutorOutput(1);

$checker = resolve(Checker::class);

$this->assertFalse($checker->checkDocker());
}

public function testErrorDockerApiVersionCommand()
{
$this->mockCommandExecutorOutput(1);

$checker = resolve(Checker::class);

$this->assertFalse($checker->checkDockerApi());
}

public function testErrorDockerComposeVersionCommand()
{
$this->mockCommandExecutorOutput(1);

$checker = resolve(Checker::class);

$this->assertFalse($checker->checkDockerCompose());
}

public function testDockerisRunning()
{
$this->mockCommandExecutorOutput(0);

$checker = resolve(Checker::class);

$this->assertTrue($checker->checkDockerIsRunning());
}

public function testDockerIsNotRunning()
{
$this->mockCommandExecutorOutput(0);

$checker = resolve(Checker::class);

$this->assertTrue($checker->checkDockerIsRunning());
}

protected function mockCommandExecutorOutput(int $exitCode, string $output = '')
{
$this->mock(CommandExecutor::class, function ($mock) use ($exitCode, $output) {
$mock->shouldReceive('runQuietly')
->andReturn($exitCode);

$mock->shouldReceive('getOutputBuffer')
->andReturn($output);
});
}
}