Fix sync resolution (gregberge#651)

* chore(tests): make breaking case for webpack4 * fix: loadableReady should not resolve synchronously, fixes gregberge#634 * chore(size): commit size change
fivethreeo · Oct 22, 2020 · 9b2eb3b · 9b2eb3b
1 parent 50c685a
commit 9b2eb3b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/.size-snapshot.json b/.size-snapshot.json
@@ -1,13 +1,13 @@
 {
   "dist/loadable.cjs.js": {
-    "bundled": 16361,
-    "minified": 7300,
-    "gzipped": 2563
+    "bundled": 16354,
+    "minified": 7304,
+    "gzipped": 2565
   },
   "dist/loadable.esm.js": {
-    "bundled": 15982,
-    "minified": 6996,
-    "gzipped": 2497,
+    "bundled": 15975,
+    "minified": 7000,
+    "gzipped": 2495,
     "treeshaked": {
       "rollup": {
         "code": 276,

diff --git a/src/loadableReady.js b/src/loadableReady.js
@@ -62,7 +62,6 @@ export default function loadableReady(
         if (!resolved) {
           resolved = true
           resolve()
-          done()
         }
       }
     }
@@ -73,5 +72,5 @@ export default function loadableReady(
     }
 
     checkReadyState()
-  })
+  }).then(done);
 }