review/jm-initial

.github/workflows/auto-release.yml

@@ -9,5 +9,5 @@ on:
 jobs:
   call-workflow-passing-data:
     if: github.event.pull_request.merged
-    uses: fivetran/dbt_package_automations/.github/workflows/auto-release.yml@feature/auto-releaser
+    uses: fivetran/dbt_package_automations/.github/workflows/auto-release.yml@main
     secrets: inherit

README.md

@@ -18,7 +18,7 @@ This package models Salesforce Marketing Cloud data from [Fivetran's connector](
 
 The main focus of the package is to transform the core object tables into analytics-ready models:
 <!--section="salesforce_marketing_cloud_model"-->
-  - Materializes [Salesforce Marketing Cloud staging tables](https://fivetran.github.io/dbt_salesforce_marketing_cloud/#!/overview/salesforce_marketing_cloud_source/models/?g_v=1) which leverage data in the format described by [this ERD](https://fivetran.com/docs/applications/salesforce_marketing_cloud/#schemainformation). The staging tables clean, test, and prepare your Salesforce Marketing Cloud data from [Fivetran's connector](https://fivetran.com/docs/applications/salesforce_marketing_cloud_source) for analysis by doing the following:
+  - Materializes [Salesforce Marketing Cloud staging tables](https://fivetran.github.io/dbt_salesforce_marketing_cloud/#!/overview/salesforce_marketing_cloud_source/models/?g_v=1) which leverage data in the format described by [this ERD](https://fivetran.com/docs/applications/salesforce_marketing_cloud/#schemainformation). The staging tables clean, test, and prepare your Salesforce Marketing Cloud data from [Fivetran's connector](https://fivetran.com/docs/applications/salesforce_marketing_cloud) for analysis by doing the following:
   - Primary keys are renamed from `id` to `<table name>_id`. 
   - Adds column-level testing where applicable. For example, all primary keys are tested for uniqueness and non-null values.
   - Provides insight into your Salesforce Marketing Cloud data across the following grains:
@@ -28,15 +28,15 @@ The main focus of the package is to transform the core object tables into analyt
 <!--section="salesforce_marketing_cloud_model"-->
 The following table provides a detailed list of all models materialized within this package by default. 
 > [!TIP]
-> See more details about these models in the package's [dbt docs site](https://fivetran.github.io/dbt_salesforce_marketing_cloud/#!/overview/qualtrics).
+> See more details about these models in the package's [dbt docs site](https://fivetran.github.io/dbt_salesforce_marketing_cloud/#!/overview).
 
 | **model** | **description**|
 | --------- | -------------- |
-| [salesforce_marketing_cloud__email_overview]() | Each record represents an email with aggregated send and event data for each. |
-| [salesforce_marketing_cloud__sends_links]() | Each record represents a link and the corresponding send(s). |
-| [salesforce_marketing_cloud__sends_overview]() | Each record represents a send with aggregated event data for each. |
-| [salesforce_marketing_cloud__subscriber_lists]() | Each record represents a list and the corresponding subscriber(s). |
-| [salesforce_marketing_cloud__subscriber_overview]() | Each record represents a subscriber with aggregated event data for each. |
+| [salesforce_marketing_cloud__email_overview]() | Each record represents an email with aggregated send and event data for each. | 
+| [salesforce_marketing_cloud__sends_links]() | Each record represents a link and the corresponding send(s). | 
+| [salesforce_marketing_cloud__sends_overview]() | Each record represents a send with aggregated event data for each. | 
+| [salesforce_marketing_cloud__subscriber_lists]() | Each record represents a list and the corresponding subscriber(s). | 
+| [salesforce_marketing_cloud__subscriber_overview]() | Each record represents a subscriber with aggregated event data for each. | 
 <!--section-end-->
 
 # 🎯 How do I use the dbt package?

dbt_project.yml

@@ -9,13 +9,14 @@ models:
     +materialized: table
     intermediate:
       +materialized: ephemeral
-      +schema: int_sfmc
+      +schema: int_sfmc 
     staging:
       +materialized: view
       +schema: stg_sfmc
 
 
 vars:
+  salesforce_marketing_cloud:
     email: "{{ source('salesforce_marketing_cloud','email') }}"
     event: "{{ source('salesforce_marketing_cloud','event') }}"
     link: "{{ source('salesforce_marketing_cloud','link') }}"

models/intermediate/salesforce_marketing_cloud__events_enhanced.sql

@@ -1,10 +1,10 @@
-{{
+{{ 
     config(
         materialized='incremental',
         unique_key='event_id',
         partition_by={'field': 'event_date', 'data_type': 'date'} if target.type not in ('spark','databricks') else ['event_date'],
         cluster_by=['event_date'],
-        incremental_strategy = 'merge' if target.type not in ('postgres', 'redshift') else 'delete+insert',
+        incremental_strategy = 'merge' if target.type not in ('postgres', 'redshift') else 'delete+insert', 
         file_format = 'delta' 
     )
 }}

models/intermediate/salesforce_marketing_cloud__subscribers_enhanced.sql

@@ -1,4 +1,4 @@
--- this is meant to be stand alone since subscribers could belong to multiple lists, and I did not want to do a list agg to include this in the subscriber overview, but open for discussion
+-- this is meant to be stand alone since subscribers could belong to multiple lists, and I did not want to do a list agg to include this in the subscriber overview, but open for discussion 
 with subscribers as ( 
   select 
     *,

models/salesforce_marketing_cloud__email_overview.sql

@@ -7,7 +7,7 @@ with emails as (
 ), sends as (
   select *
   from {{ ref('stg_salesforce_marketing_cloud__send') }}
-  where not _fivetran_deleted
+  where not _fivetran_deleted 
 
 ), sends_stats as (
   select 
@@ -31,9 +31,9 @@ with emails as (
 ), sends_aggs as (
   select
     sends_stats.*,
-    coalesce(total_unique_opens / nullif(total_emails_sent, 0), 0) as open_rate, --use safe divide in dbt
-    coalesce(total_unique_clicks / nullif(total_emails_sent, 0), 0) as click_through_rate, --use safe divide in dbt
-    coalesce(total_unsubscribes / nullif(total_emails_sent, 0), 0) as unsubscribe_rate --use safe divide in dbt
+    coalesce(total_unique_opens / nullif(total_emails_sent, 0), 0) as open_rate, --use safe divide in dbt 
+    coalesce(total_unique_clicks / nullif(total_emails_sent, 0), 0) as click_through_rate, --use safe divide in dbt 
+    coalesce(total_unsubscribes / nullif(total_emails_sent, 0), 0) as unsubscribe_rate --use safe divide in dbt 
   from sends_stats
 
 ), events_enhanced as ( 
@@ -62,7 +62,7 @@ with emails as (
 
 ), joined as (
   select
-    emails.*,
+    emails.*, 
     sends_aggs.total_unique_sends,
     sends_aggs.total_emails_sent,
     sends_aggs.total_unique_opens,
@@ -72,8 +72,8 @@ with emails as (
     sends_aggs.total_deliveries,
     sends_aggs.total_targets,
     sends_aggs.total_bounces,
-    sends_aggs.open_rate, --use safe divide in dbt
-    sends_aggs.click_through_rate, --use safe divide in dbt
+    sends_aggs.open_rate, --use safe divide in dbt 
+    sends_aggs.click_through_rate, --use safe divide in dbt 
     sends_aggs.unsubscribe_rate,
     events_stats.total_send_events,
     events_stats.total_open_events,

models/salesforce_marketing_cloud__sends_links.sql

@@ -4,15 +4,15 @@
 with sends as (
   select *
   from {{ ref('stg_salesforce_marketing_cloud__send') }}
-  where not _fivetran_deleted
+  where not _fivetran_deleted 
 
 ), link_sends as (
   select *
-  from {{ ref('stg_salesforce_marketing_cloud__link_send') }}
+  from {{ ref('stg_salesforce_marketing_cloud__link_send') }} 
 
 ), links as (
   select *
-  from {{ ref('stg_salesforce_marketing_cloud__link') }}
+  from {{ ref('stg_salesforce_marketing_cloud__link') }} 
 
 ), joined as (
   select 

models/salesforce_marketing_cloud__sends_overview.sql

@@ -7,9 +7,9 @@ with sends as (
 ), sends_aggs as (
   select
     sends.*,
-    coalesce(unique_opens / nullif(number_sent, 0), 0) as open_rate, --use safe divide in dbt
-    coalesce(unique_clicks / nullif(number_sent, 0), 0) as click_through_rate, --use safe divide in dbt
-    coalesce(unsubscribes / nullif(number_sent, 0), 0) as unsubscribe_rate --use safe divide in dbt
+    coalesce(unique_opens / nullif(number_sent, 0), 0) as open_rate, --use safe divide in dbt 
+    coalesce(unique_clicks / nullif(number_sent, 0), 0) as click_through_rate, --use safe divide in dbt 
+    coalesce(unsubscribes / nullif(number_sent, 0), 0) as unsubscribe_rate --use safe divide in dbt 
   from sends
 
 ), events_enhanced as ( 
@@ -35,7 +35,7 @@ with sends as (
 
 ), joined as (
   select
-    sends_aggs.*,
+    sends_aggs.*, 
     events_stats.total_send_events,
     events_stats.total_open_events,
     events_stats.total_click_events,

models/salesforce_marketing_cloud__subscriber_lists.sql

@@ -10,7 +10,7 @@ with subscribers as (
   from {{ ref('stg_salesforce_marketing_cloud__list_subscriber') }}
   where coalesce(_fivetran_active, true)
 
-), lists as ( --make lists optional
+), lists as ( --make lists optional 
   select *
   from {{ ref('stg_salesforce_marketing_cloud__list') }}
   where coalesce(_fivetran_active, true)

models/staging/stg_salesforce_marketing_cloud__email.sql

@@ -26,9 +26,9 @@ final as (
 
     select 
         source_relation, 
-        _fivetran_start,
-        _fivetran_end,
-        _fivetran_active,
+        _fivetran_start, 
+        _fivetran_end, 
+        _fivetran_active, 
         _fivetran_synced,
         asset_id,
         asset_type_id,

models/staging/stg_salesforce_marketing_cloud__event.sql

@@ -26,7 +26,7 @@ final as (
 
     select 
         source_relation, 
-        _fivetran_deleted,
+        _fivetran_deleted, 
         _fivetran_synced,
         batch_id,
         bounce_category,