review/jm-initial #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@fivetran-catfritz this package is looking great! Please see below for my comments and suggestions. I am happy to chat about any of them if you would like.
models/intermediate/salesforce_marketing_cloud__subscribers_enhanced.sql
Show resolved
Hide resolved
models/intermediate/salesforce_marketing_cloud__subscribers_enhanced.sql
Show resolved
Hide resolved
|
Thanks @fivetran-catfritz for going through all of my review notes and applying the necessary changes! This package is looking great and should be ready to go with just a few minor last minute edits. I will close out this PR, but if you can review and merge in PR #2 to address the last minute changes that would be great! Let me know if you have any questions. We can then discuss release plans. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to serve as an initial review of the Salesforce Marketing Cloud dbt package. This PR is not intended to be merged into
main. Please see the review comments below and address the notes within themainbranch. Once the comment has been addressed, please comment as such and do not resolve the comment. I will resolve the comments upon final review.