review/jm-final #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,7 +21,7 @@ with subscribers as ( | |||
| case when subscribers.unsubscribed_date is not null | |||
| then {{ dbt.datediff("subscribers.created_date", "subscribers.unsubscribed_date", "day") }} | |||
| else {{ dbt.datediff("subscribers.created_date", "current_date", "day") }} | |||
| end as days_subscribed, | |||
| end as days_subscribed, | |||
There was a problem hiding this comment.
Small formatting edit to be consistent with our style standards.
Comment on lines
+1
to
+18
| database_key: salesforce_marketing_cloud_database | ||
| schema_key: salesforce_marketing_cloud_schema | ||
|
|
||
| dbt_versions: ">=1.3.0 <2.0.0" | ||
|
|
||
| table_variables: | ||
| salesforce_marketing_cloud__link_enabled: | ||
| - link_send | ||
| - link | ||
| salesforce_marketing_cloud__list_enabled: | ||
| - list_subscriber | ||
| - list | ||
|
|
||
| destination_configurations: | ||
| databricks: | ||
| dispatch: | ||
| - macro_namespace: dbt_utils | ||
| search_order: [ 'spark_utils', 'dbt_utils' ] |
There was a problem hiding this comment.
New addition of the quickstart.yml where the format was just finalized yesterday.
Closed
fivetran-catfritz
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final updates as part of my last review. This PR is intended to be reviewed and merged into
main.