Documentation Standard Updates #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fivetran-catfritz when you have a chance would you be able to review this PR? This way we can batch it along with the other changes planned for the |
fivetran-catfritz
requested changes
Aug 29, 2024
There was a problem hiding this comment.
One of the exclamation marks made it through, but otherwise is in order! @fivetran-joemarkiewicz
Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com>
|
@fivetran-catfritz thanks for catching that. Let me know if this is good for approval following that change. |
Merged
fivetran-catfritz
added a commit
that referenced
this pull request
Sep 4, 2024
* initial * feature/unstructured-data * add coalesce_cast * update filters * update and consolidate models * model revisions * restructure * documentation * remove extra comma * regen docs * formatting * update max token docs * Update CHANGELOG.md * bug/missing-sla-policies * update changelog and add integrity test * update test * update changelog, readme and tests * update test * bug/intercepted-period-joins * adjustmnt * update weeks * update weeks * add integrity test * update weeks * update changelog * bugfix/too-many-partitions (#165) * bugfix/too-many-partitions * docs regen * Update CHANGELOG.md Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com> --------- Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com> * update changelog * revert docs to main * Documentation Standard Updates (#166) * MagicBot/documentation-updates * Apply suggestions from code review * Update README.md Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com> --------- Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com> * update default max_tokens * update changelog * Apply suggestions from code review Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com> * update readme * regen docs * update yml * Apply suggestions from code review Co-authored-by: Renee Li <91097070+fivetran-reneeli@users.noreply.github.com> * add comments and update changelog * update changelog * Update packages.yml --------- Co-authored-by: Renee Li <renee.li@fivetran.com> Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com> Co-authored-by: Renee Li <91097070+fivetran-reneeli@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request was created automatically 🎉:
.github/files have been properly updated (templates are updated and auto releaser is included).quickstart/quickstart.ymlfile aspublic_models(only for transform repos)**modelto**table**(only for transform repos)