Release/v0.17.0 #169
Merged
Release/v0.17.0 #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update agent work time and requester wait time business hours models
bug/intercepted-period-joins
* bugfix/too-many-partitions * docs regen * Update CHANGELOG.md Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com> --------- Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com>
* MagicBot/documentation-updates * Apply suggestions from code review * Update README.md Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com> --------- Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com>
7 tasks
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Feature/unstructured data
fivetran-joemarkiewicz
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Thanks for all the effort here @fivetran-catfritz!
These changes look good to me. This is ready for release review and rollout!
fivetran-reneeli
requested changes
Sep 4, 2024
models/sla_policy/requester_wait_time/int_zendesk__requester_wait_time_business_hours.sql
Show resolved
Hide resolved
CHANGELOG.md
Outdated
| - `chunk`: The text chunk itself | ||
| - `chunk_tokens_approximate`: Approximate token count for each segment | ||
| - This model is currently disabled by default. You may enable it by setting the `zendesk__unstructured_enabled` variable as `true` in your `dbt_project.yml`. | ||
| - This model was developed to limit the chunk sizes to approximately 5000 tokens for use with OpenAI, however you can change this limit by setting the variable `zendesk_max_tokens` in your `dbt_project.yml`. |
There was a problem hiding this comment.
Are we only intending to use Zendesk NLP with Open AI which I feel is the language here? Or we want to be agnostic.
I would also reword it to the following:
This model was developed with the limit of chunk sizes to approximately 5000 tokens for use with OpenAI, however you can change this limit by setting the variable `zendesk_max_tokens` in your `dbt_project.yml`.
There was a problem hiding this comment.
Thanks! updated.
CHANGELOG.md
Outdated
| ## Under the hood | ||
| - Added integrity validations: | ||
| - Test to ensure `zendesk__sla_policies` and `zendesk__ticket_metrics` models produce consistent time results. ([#164](https://github.com/fivetran/dbt_zendesk/pull/164)) | ||
| - Test to ensure `zendesk__ticket_metrics` contains all the tickets found in `stg_zendesk__ticket`. |
There was a problem hiding this comment.
Also add PR link here?
models/resolution_times/int_zendesk__ticket_first_resolution_time_business.sql
Show resolved
Hide resolved
Co-authored-by: Renee Li <91097070+fivetran-reneeli@users.noreply.github.com>
There was a problem hiding this comment.
Thanks for the review @fivetran-reneeli! I added comments inline to address your questions and also made the changelog updates you suggested. Let me know if it all looks good!
models/sla_policy/requester_wait_time/int_zendesk__requester_wait_time_business_hours.sql
Show resolved
Hide resolved
CHANGELOG.md
Outdated
| - `chunk`: The text chunk itself | ||
| - `chunk_tokens_approximate`: Approximate token count for each segment | ||
| - This model is currently disabled by default. You may enable it by setting the `zendesk__unstructured_enabled` variable as `true` in your `dbt_project.yml`. | ||
| - This model was developed to limit the chunk sizes to approximately 5000 tokens for use with OpenAI, however you can change this limit by setting the variable `zendesk_max_tokens` in your `dbt_project.yml`. |
There was a problem hiding this comment.
Thanks! updated.
CHANGELOG.md
Outdated
| ## Under the hood | ||
| - Added integrity validations: | ||
| - Test to ensure `zendesk__sla_policies` and `zendesk__ticket_metrics` models produce consistent time results. ([#164](https://github.com/fivetran/dbt_zendesk/pull/164)) | ||
| - Test to ensure `zendesk__ticket_metrics` contains all the tickets found in `stg_zendesk__ticket`. |
fivetran-reneeli
approved these changes
Sep 4, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This release branch contains PRs:
For specifics and validation details, refer to the above linked PRs.