fix(#3): add a workaround for stripped wasm symbols #4
Conversation
| @@ -17,6 +17,16 @@ env: | |||
| RUSTFLAGS: "-Dwarnings" | |||
|
|
|||
| jobs: | |||
| build: | |||
There was a problem hiding this comment.
Just to document the fix
There was a problem hiding this comment.
I don't think it is necessary. The bug seems to be in wasm-bindgen, so we shouldn't add any regressions for it.
| @@ -3,3 +3,6 @@ members=[ | |||
| 'wasm-bindgen-derive', | |||
| 'tests' | |||
| ] | |||
|
|
|||
| [profile.release] | |||
| opt-level = 1 | |||
There was a problem hiding this comment.
Please add an explanation and a link to rustwasm/wasm-bindgen#3457 here.
I am still not quite sure how to reproduce the bug properly; when compiling wasm-bindgen-derive, it only occurs for a release build, but in my test above it happens in both release and debug builds (and in the failed nucypher-core CI it also happened in debug, namely during a clippy run)
|
Small nitpick, you can just write "Fixes #3" in the PR description, that will link the issue, and close it automatically on merge. Also, if I understand it correctly, adding |
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
=======================================
Coverage 80.91% 80.91%
=======================================
Files 1 1
Lines 131 131
=======================================
Hits 106 106
Misses 25 25 |
|
Closing in favor of #5 |
No description provided.