Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#3): add a workaround for stripped wasm symbols #4

Closed
wants to merge 1 commit into from
Closed

fix(#3): add a workaround for stripped wasm symbols #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,16 @@ env:
RUSTFLAGS: "-Dwarnings"

jobs:
build:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to document the fix

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is necessary. The bug seems to be in wasm-bindgen, so we shouldn't add any regressions for it.

runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- uses: actions-rs/toolchain@v1
with:
toolchain: stable
override: true
profile: minimal
- run: cargo build --release

clippy:
runs-on: ubuntu-latest
Expand Down
3 changes: 3 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,6 @@ members=[
'wasm-bindgen-derive',
'tests'
]

[profile.release]
opt-level = 1
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an explanation and a link to rustwasm/wasm-bindgen#3457 here.

I am still not quite sure how to reproduce the bug properly; when compiling wasm-bindgen-derive, it only occurs for a release build, but in my test above it happens in both release and debug builds (and in the failed nucypher-core CI it also happened in debug, namely during a clippy run)