Discord IDが不正でも退会できるようにした #4220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tksmasaki |
eatplaynap
force-pushed
the
bug/enable-retirement-regardless-validity-of-discord-id
branch
from
36eba8d to
2bd3911
Compare
tksmasaki
reviewed
Feb 17, 2022
There was a problem hiding this comment.
@eatplaynap
お疲れさまです。
レビューさせていただきました！ 1点コメントしたので、確認よろしくお願いします🙏
validation_context を使った覚えが無かったので、勉強になりました！
test/system/retirement_test.rb
Outdated
| visit_with_auth new_retirement_path, 'discordinvalid' | ||
| choose 'とても悪い', visible: false | ||
| click_on '退会する' | ||
| page.driver.browser.switch_to.alert.accept |
There was a problem hiding this comment.
Capybara の accept_comfirm を用いたほうが適切そうです。
一個の下のテストでも使われていました。
bootcamp/test/system/retirement_test.rb
Line 63 in 2bd3911
There was a problem hiding this comment.
なるほど！知らなかったです、ありがとうございます:pray:
ご指摘の通りに修正してみました！
eatplaynap
force-pushed
the
bug/enable-retirement-regardless-validity-of-discord-id
branch
from
2bd3911 to
2e39563
Compare
|
@tksmasaki |
|
@tksmasaki @komagata |
komagata
deleted the
bug/enable-retirement-regardless-validity-of-discord-id
branch
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue概要
DiscordのIDが「ユーザー名#４桁の数字」以外だと不正な値と見なされ、退会処理が行えませんでした。
こちらをDiscordのIDが「ユーザー名#４桁の数字」以外のユーザーでも退会処理が行えるよう修正し、テストを追加しました。
※app/models/user.rbは、本Issueとは直接関係ない箇所もlinterをかけて自動修正された結果変更されています。
Discord IDが不正なユーザー
修正前
修正後
kimura#12345678という不正なDiscord IDのユーザーが退会処理を行った↑後、↓のページに飛ぶようになりました確認方法
bug/enable-retirement-regardless-validity-of-discord-idをローカルに取り込むdb/fixtures/users.yml内のユーザーのDiscord IDを不正な値に変更する(手元ではkimuraのdiscord_accountをkimura#12345678にして確認しました)bin/rails db:seedでユーザー情報を取り込むbin/rails sでサーバーを立ち上げるkimuraでログインする退会・休会手続きに進む退会するボタンで無事退会できることを確認する手順が分かりづらかったら直接お声かけください。