Twitter IDが不正でも退会できるように修正 #4321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clio209
force-pushed
the
bug/enable-retirement-regardless-validity-of-twitter-id
branch
from
383cfc8 to
1d71e60
Compare
clio209
changed the title
clio209
force-pushed
the
bug/enable-retirement-regardless-validity-of-twitter-id
branch
from
1d71e60 to
a8982cc
Compare
|
@eatplaynap さん |
eatplaynap
requested changes
Mar 11, 2022
There was a problem hiding this comment.
@clio209
レビュー依頼ありがとうございます！私の立てたIssueへのご対応もありがとうございます😄 db/fixtures/users.ymlへの当該するユーザー情報の登録がされていて、rails db:seedだけでtwitterのIDが不正なユーザーが作れるのがありがたかったです〜！
コード自体は問題なさそうでしたが、2点だけご対応お願いします。
- PRがまだドラフトなのでready for reviewに変更をお願いします💪
- descriptionに下記の手順がありますが、
db/fixtures/users.ymlに不正なtwitter IDユーザーがすでに存在しているのでこの部分は削ってよさそうです。-
2.
db/fixtures/users.ymlのユーザーのtwitter IDを1つ不正な値に変更します。
-
|
@eatplaynap |
eatplaynap
approved these changes
Mar 11, 2022
|
@eatplaynap 再レビュー、有難うございます！ |
komagata
deleted the
bug/enable-retirement-regardless-validity-of-twitter-id
branch
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #4224
概要
変更前
このように、twitterコードが不正の場合、エラーが出て退会できません。
変更後
退会の際はこのエラーの元になるバリデーションを外すことで退会を可能にしています。
#4220
こちらと同様のエラーを解消するissueであり、大変参考にしています。
確認方法
bug/enable-retirement-regardless-validity-of-twitter-idをローカルに取り込みます。bin/rails db:seedでユーザー情報をデータに取り込み、bin/rails sでサーバーを立ち上げます。twitterinvalidでログインします。