-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Drop dependency on fact_helper_file #1140
base: master
Are you sure you want to change the base?
Conversation
402d528
to
ea0845f
Compare
While I don't really care note that the repo is in my namespace and not fkiecad's. |
ea0845f
to
855101f
Compare
This is blocked on ahupp/python-magic#304 which allows us to delete |
855101f
to
fda3e23
Compare
Seems that I and the python-magic developer disagree on what a good public API for the magic module would be. Regarding the FACT extractor I don't think we need to copy this code since the only thing it ever needs is |
fda3e23
to
02405dd
Compare
02405dd
to
3722e15
Compare
Assuming that fkie-cad/fact_extractor#128 works and is merged this is ready for review. |
c5b6ce0
to
236a975
Compare
236a975
to
eba377d
Compare
eba377d
to
97bede4
Compare
It is replaced by the much simpler magic.py
97bede4
to
ebf366f
Compare
This uses https://github.com/maringuu/fact-mime-database which is imo the only relevant thing that fact_helper_file provides.
Before merging we should somehow incoperate that fact_helper_file/mime/custom_mime_internal is missing.
If would be great if we could add this somehow add to the FACT_core repo to make fact-mime-database not use its generality.