Drop dependency on fact_helper_file #128
Conversation
Still not great as the whole installation happens after copying but at least not copying is not the first thing we do. Related #124
The only benefit it provides over the python package magic is that it includes some additional magic. Now that this file is in its own repo we can simple use the MAGIC environment variable. As the fact_extractor is only ever run in docker it suffices to set this in the dockerfile.
maringuu
force-pushed
the
drop-fact-helper-file
branch
from
d5b3635
to
a003405
Compare
|
Converting to draft as we must somehow tell pytest that it should execute the tests with the proper MAGIC variable. |
The extractor needs the same functionality as FACT: using the custom MIME definitions and if that does not work fall back to the regular ones. Because the regular ones are not a subset of the custom MIMEs and we are missing some important ones if we don't have this fallback (probably .zip, .tar, etc.). That is probably also the reason that the tests don't work. This is why this logic was put into the "fact_helper_file" module. It is probably necessary to take the code from fkie-cad/FACT_core#1140 and use it to refactor fact_helper_file. |
See individual commits.
Related fkie-cad/FACT_core#1140