feat: add discussion sortmap to container binding (#3377)

flarum · Apr 4, 2022 · 1d27f62 · 1d27f62
1 parent 9d9594a
commit 1d27f62
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 16 deletions.
diff --git a/framework/core/src/Forum/Content/Index.php b/framework/core/src/Forum/Content/Index.php
@@ -70,7 +70,7 @@ public function __invoke(Document $document, Request $request)
         $page = max(1, intval(Arr::pull($queryParams, 'page')));
         $filters = Arr::pull($queryParams, 'filter', []);
 
-        $sortMap = $this->getSortMap();
+        $sortMap = resolve('flarum.forum.discussions.sortmap');
 
         $params = [
             'sort' => $sort && isset($sortMap[$sort]) ? $sortMap[$sort] : '',
@@ -96,21 +96,6 @@ public function __invoke(Document $document, Request $request)
         return $document;
     }
 
-    /**
-     * Get a map of sort query param values and their API sort params.
-     *
-     * @return array
-     */
-    private function getSortMap()
-    {
-        return [
-            'latest' => '-lastPostedAt',
-            'top' => '-commentCount',
-            'newest' => '-createdAt',
-            'oldest' => 'createdAt'
-        ];
-    }
-
     /**
      * Get the result of an API request to list discussions.
      *

diff --git a/framework/core/src/Forum/ForumServiceProvider.php b/framework/core/src/Forum/ForumServiceProvider.php
@@ -129,6 +129,15 @@ public function register()
         $this->container->bind('flarum.frontend.forum', function (Container $container) {
             return $container->make('flarum.frontend.factory')('forum');
         });
+
+        $this->container->singleton('flarum.forum.discussions.sortmap', function () {
+            return [
+                'latest' => '-lastPostedAt',
+                'top' => '-commentCount',
+                'newest' => '-createdAt',
+                'oldest' => 'createdAt'
+            ];
+        });
     }
 
     public function boot(Container $container, Dispatcher $events, Factory $view)