Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add discussion sortmap to container binding #3377

Merged
merged 2 commits into from
Apr 4, 2022
Merged

Add discussion sortmap to container binding #3377

merged 2 commits into from
Apr 4, 2022

Conversation

imorland
Copy link
Member

@imorland imorland commented Apr 4, 2022

Recreates #3254

@luceos
Copy link
Member

luceos commented Apr 4, 2022

This implementation is indeed much easier, but could you change the name of the container binding to include index or discussions? Does that make sense?

askvortsov1
askvortsov1 approved these changes Apr 4, 2022
View reviewed changes
Copy link
Sponsor Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, let's use discussions

@imorland
Copy link
Member Author

imorland commented Apr 4, 2022

Voila :)

@askvortsov1 askvortsov1 merged commit 1d27f62 into main Apr 4, 2022
@askvortsov1 askvortsov1 deleted the im/sortmap-binding branch April 4, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luceos luceos luceos approved these changes

@askvortsov1 askvortsov1 askvortsov1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imorland @luceos @askvortsov1