Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme file for Statistics extension? #3604

Closed
orschiro opened this issue Aug 16, 2022 · 7 comments · Fixed by #3654
Closed

Readme file for Statistics extension? #3604

orschiro opened this issue Aug 16, 2022 · 7 comments · Fixed by #3654
Labels

Comments

@orschiro
Copy link

Current Behavior

Hi all,

Could https://github.com/flarum/statistics add a readme file that explains the basics of this extension?

For example what the green and grey line mean and what the difference between the two is.

That's not really clear from just looking at it (at least for me).

Thanks!

Steps to Reproduce

  1. Install the extension
  2. No readme file present

Expected Behavior

There should be a readme file that explains the basics.

Screenshots

image

image

Environment

  • Flarum version: 1.4.0

Output of php flarum info

No response

Possible Solution

No response

Additional Context

No response

@SychO9
Copy link
Member

SychO9 commented Aug 16, 2022

This isn't a bug though 😅

I honestly don't know what the gray line means either. The extension needs a refactor/rewrite imo.

@davwheat
Copy link
Member

Grey line is the last period -- same data as is used for the % comparisons

@orschiro
Copy link
Author

orschiro commented Aug 16, 2022 via email

@davwheat
Copy link
Member

Yep, spot on!

@orschiro
Copy link
Author

orschiro commented Aug 17, 2022 via email

@SychO9
Copy link
Member

SychO9 commented Oct 2, 2022

@orschiro are the changes in the linked PR better? (screenshots)

@orschiro
Copy link
Author

orschiro commented Oct 2, 2022

@SychO9 yes, much better, thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants